Skip to content

Commit

Permalink
Rename dataset.* to datastream.* (#618)
Browse files Browse the repository at this point in the history
* Rename dataset to datastream

* Update CHANGELOG

* Address PR comments

* Fix
  • Loading branch information
mtojek authored Aug 4, 2020
1 parent 2ce65dd commit 737fb54
Show file tree
Hide file tree
Showing 12 changed files with 65 additions and 63 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Breaking changes

* Change dataset.* fields to datastream.* fields. [#618](https://github.com/elastic/package-registry/pull/618)

### Bugfixes

### Added
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,24 @@
description: >
Event timestamp.
- name: dataset
title: dataset
- name: datastream
title: datastream
group: 2
description: Fields describing the new indexing strategy <type>-<name>-<namespace>
type: group
fields:
- name: name
- name: dataset
level: custom
type: constant_keyword
description: Dataset name.
description: Datastream dataset.
default_field: false
- name: namespace
level: custom
type: constant_keyword
description: Dataset namespace.
description: Datastream namespace.
default_field: false
- name: type
level: custom
type: constant_keyword
description: Dataset type.
description: Datastream type.
default_field: false
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
- name: dataset.type
- name: datastream.type
type: constant_keyword
description: >
Dataset type.
- name: dataset.name
Datastream type.
- name: datastream.dataset
type: constant_keyword
description: >
Dataset name.
- name: dataset.namespace
Datastream dataset.
- name: datastream.namespace
type: constant_keyword
description: >
Dataset namespace.
Datastream namespace.
- name: "@timestamp"
type: date
description: >
Expand Down
6 changes: 3 additions & 3 deletions util/dataset.go
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,9 @@ func (d *Dataset) validateRequiredFields() error {
}

// Verify required keys
err = requireField(allFields, "dataset.type", "constant_keyword", err)
err = requireField(allFields, "dataset.name", "constant_keyword", err)
err = requireField(allFields, "dataset.namespace", "constant_keyword", err)
err = requireField(allFields, "datastream.type", "constant_keyword", err)
err = requireField(allFields, "datastream.dataset", "constant_keyword", err)
err = requireField(allFields, "datastream.namespace", "constant_keyword", err)
err = requireField(allFields, "@timestamp", "date", err)
return err
}
Expand Down

0 comments on commit 737fb54

Please sign in to comment.