Replace alert workflow status filter with status filter #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon: |
bmorelli25
approved these changes
Mar 28, 2022
|
Hi @colleenmcginnis looks good, couple of comments on the "Filter alerts" section of the "View Alerts" doc page:
|
|
Thanks @vinaychandrasekhar. I made a couple updates based on your comments in 59d3311.
I couldn't find a good definition of each status aside from what the |
|
@colleenmcginnis Here are the definitions after discussion with @simianhacker "Active" - An alert is "active" when the condition defined in the rule currently matches. |
vinaychandrasekhar
approved these changes
Mar 30, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
* update screenshot, remove references to changing workflow status * mention using buttons to filter by alert status * add definitions of active and recovered (cherry picked from commit 71779aa)
mergify bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
* update screenshot, remove references to changing workflow status * mention using buttons to filter by alert status * add definitions of active and recovered (cherry picked from commit 71779aa)
colleenmcginnis
added a commit
that referenced
this pull request
Mar 30, 2022
* update screenshot, remove references to changing workflow status * mention using buttons to filter by alert status * add definitions of active and recovered (cherry picked from commit 71779aa) Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
colleenmcginnis
added a commit
that referenced
this pull request
Mar 30, 2022
* update screenshot, remove references to changing workflow status * mention using buttons to filter by alert status * add definitions of active and recovered (cherry picked from commit 71779aa) Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1414
Fixes #1478
Replaces the screenshot of the Alerts page and removes references to updating/filtering by workflow status of alerts.