Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate --url is required when enrolling a fleet server with a cert #1263

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Nov 15, 2021

Closes elastic/beats#27245

This is a loose backport of #1091 without most of the changes/improvements from the later PR. My main goal is to get the syntax right for 7.14 with minimal changes since we don't currently release doc bug fixes for 7.14 and earlier.

@ppf2
Copy link
Member

ppf2 commented Nov 15, 2021

@dedemorton I see that the changed file is replacing --insecure option with --url. Did we mean to add the --url option, not to replace --insecure? I think it is best for a Fleet Server developer to be the technical reviewer to confirm the current/correct settings. Thx!

@dedemorton
Copy link
Contributor Author

@ppf2 Thanks for looking! For 7.14, the --insecure option wasn't used when enrolling a fleet server and shouldn't have been included in the syntax or example. It was causing confusion about where the flag was being applied.

Recently we did introduce a --fleet-server-es-insecure flag (elastic/beats#28007 and #1159), but that's not available in 7.14.

@michalpristas -- Can you review this change for 7.14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants