Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elastic-agent diagnostics documentation #1164

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 13, 2021
@michel-laterman michel-laterman requested a review from a team as a code owner October 13, 2021 20:58
@apmmachine
Copy link
Contributor

apmmachine commented Oct 13, 2021

A documentation preview will be available soon:

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! Just a few minor edits and a request to change the order of the content.

docs/en/ingest-management/commands.asciidoc Outdated Show resolved Hide resolved
@@ -15,6 +15,7 @@ doing common tasks:
* <<elastic-agent-uninstall-command,uninstall>>
* <<elastic-agent-upgrade-command,upgrade>>
* <<elastic-agent-version-command,version>>
* <<elastic-agent-diagnostics-command,diagnostics>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands are alphabetized, so move this one to the top.

@@ -669,6 +670,45 @@ elastic-agent version
<hr>
++++

[discrete]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as before. Move this to the top section because it appears first alphabetically.

docs/en/ingest-management/commands.asciidoc Outdated Show resolved Hide resolved
michel-laterman and others added 2 commits October 15, 2021 13:13
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michel-laterman michel-laterman merged commit 886949b into elastic:master Oct 15, 2021
@michel-laterman michel-laterman deleted the agent-diagnostics branch October 15, 2021 21:00
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
* Add elastic-agent diagnostics documentation

* Fix typo

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

* Move diagnostics command to top

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants