NG Pipeline #4363
Closed
NG Pipeline #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
@andrewvc Merge conflicts?
|
@suyograo are you sure there are merge conflicts? Github says there aren't. I rebased it against the 2.x branch when I made this. |
ff274dc to
27c756d
Compare
27c756d to
9f3a44a
Compare
|
LGTM. Detailed reviews were done in #4340 |
|
Andrew Cholakian merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the ng_pipeline patches from master to the 2.x branch as one squashed commit.