Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shutdown controller when using no filters #4284

Merged
merged 1 commit into from
Nov 30, 2015

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Nov 27, 2015

initializes @filter_threads to be an empty array so that the Shutdown controller can deal with no filters gracefully.

this needs to be merged into master, 2.x and 2.1

fixes #4271

@jsvd jsvd added the bug label Nov 27, 2015
@andrewvc
Copy link
Contributor

Does this need to be merged into master of the new pipeline is to be merged
soon?

On Friday, November 27, 2015, João Duarte notifications@github.com wrote:

initializes @filter_threads to be an empty array so that the Shutdown
controller can deal with no filters gracefully.

this needs to be merged into master, 2.x and 2.1

fixes #4271 #4271

You can view, comment on, or merge this pull request online at:

#4284
Commit Summary

  • fix shutdown controller when using no filters

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#4284.

@jsvd
Copy link
Member Author

jsvd commented Nov 27, 2015

@andrewvc it's not mandatory though I don't see harm in it.

@ph
Copy link
Contributor

ph commented Nov 27, 2015

LGTM

@andrewvc
Copy link
Contributor

@jsvd I think it would make sense not to merge this into master given that it's just going to create a merge conflict when the new pipeline is merged in. Just my $0.02

@suyograo
Copy link
Contributor

@jsvd can you merge this to 2.1 and 2.x? I will create a release tomorrow

@jsvd jsvd mentioned this pull request Nov 30, 2015
@jsvd jsvd merged commit 21dfae1 into elastic:2.x Nov 30, 2015
@jsvd jsvd deleted the fix_shutdown_controller_no_filters branch November 30, 2015 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants