-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tins to 1.6 #4164
Fix tins to 1.6 #4164
Conversation
LGTM |
this is such a straightforward fix I am comfortable with a quick merge, plus I am stumbling on this now :P |
+1 will update the PR with the comment. |
@colinsurprenant concerning the comment where do you want it? In the Gemfile there is risk it will be removed?
|
its not a problem, the comment will be in the repo, it will be lost when executing plugin manager commands but that's not important. what's important is that we have the comment in the source tree repo so that when we modify and look at it we understand what's going on |
The 1.6 releases is the latest release to support ruby 1.9 Fixes: #4163
e91da5f
to
b91a1b6
Compare
Updated with a comment, |
Merged sucessfully into master 1.5 2.0 2.1! |
The 1.6 release is the latest release to support ruby 1.9
Fixes: #4163