Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tins to 1.6 #4164

Closed
wants to merge 1 commit into from
Closed

Fix tins to 1.6 #4164

wants to merge 1 commit into from

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 10, 2015

The 1.6 release is the latest release to support ruby 1.9

Fixes: #4163

@ph ph added the v2.1.0 label Nov 10, 2015
@colinsurprenant
Copy link
Contributor

LGTM
maybe add a comment explaining that tins a requirement of term-ansi-color which is in turn a requirement of coveralls and 1.6 release is required until we switch to a Ruby 2.0 compliant JRuby ?

@colinsurprenant
Copy link
Contributor

this is such a straightforward fix I am comfortable with a quick merge, plus I am stumbling on this now :P

@ph
Copy link
Contributor Author

ph commented Nov 11, 2015

+1 will update the PR with the comment.

@ph
Copy link
Contributor Author

ph commented Nov 11, 2015

@colinsurprenant concerning the comment where do you want it? In the Gemfile there is risk it will be removed?

# If you modify this file manually all comments and formatting will be lost. :)

@colinsurprenant
Copy link
Contributor

its not a problem, the comment will be in the repo, it will be lost when executing plugin manager commands but that's not important. what's important is that we have the comment in the source tree repo so that when we modify and look at it we understand what's going on

The 1.6 releases is the latest release to support ruby 1.9
Fixes: #4163
@ph ph force-pushed the fix/fix-tins-to-1.6 branch from e91da5f to b91a1b6 Compare November 11, 2015 20:13
@ph
Copy link
Contributor Author

ph commented Nov 11, 2015

Updated with a comment,
This need to be merged in master 1.5, 1.5, 2.0, 2.1

@elasticsearch-bot
Copy link

Merged sucessfully into master 1.5 2.0 2.1!

ph added a commit that referenced this pull request Nov 11, 2015
The 1.6 releases is the latest release to support ruby 1.9
Fixes: #4163

Fixes #4164
@ph ph closed this in 2e2b96f Nov 11, 2015
ph added a commit that referenced this pull request Nov 11, 2015
The 1.6 releases is the latest release to support ruby 1.9
Fixes: #4163

Fixes #4164
ph added a commit that referenced this pull request Nov 11, 2015
The 1.6 releases is the latest release to support ruby 1.9
Fixes: #4163

Fixes #4164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants