fix default argument handling in rake artifact task #13904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this please |
kares
approved these changes
Mar 17, 2022
5825f25 to
0439611
Compare
Ruby allows methods to have default values in arguments if they're not passed. However if a nil is passed then the default value isn't used. The artifact:archives tasks were passing nil values to the exclusion argument, causing all files to be included in the package. This commit cleans the naming of the path lists and ensures the default exclusion list is always used.
0439611 to
785a0c6
Compare
|
@logstashmachine backport 8.1 |
jsvd
added a commit
that referenced
this pull request
Mar 18, 2022
Ruby allows methods to have default values in arguments if they're not passed. However if a nil is passed then the default value isn't used. The artifact:archives tasks were passing nil values to the exclusion argument, causing all files to be included in the package. This commit cleans the naming of the path lists and ensures the default exclusion list is always used.
jsvd
added a commit
that referenced
this pull request
Mar 18, 2022
Ruby allows methods to have default values in arguments if they're not passed. However if a nil is passed then the default value isn't used. The artifact:archives tasks were passing nil values to the exclusion argument, causing all files to be included in the package. This commit cleans the naming of the path lists and ensures the default exclusion list is always used.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby allows methods to have default values in arguments if they're not
passed. However if a nil is passed then the default value isn't used.
The artifact:archives tasks were passing nil values to the exclusion
argument, causing all files to be included in the package.
This commit cleans the naming of the path lists and ensures the default
exclusion list is always used.
To test this the reviewer can run
rake artifact:archivesand then confirm that the produced archives don't include files such as "bin/bundle" or in the case of OSS archives, the "x-pack" folder.