Doc: Add shared attribute for messaging ecs default info #13083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hi @yaauie I would appreciate your comments on the usefulness and content of this PR. |
0129521 to
13b71de
Compare
13b71de to
27cfb73
Compare
yaauie
reviewed
Sep 27, 2021
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
karenzone
added a commit
to karenzone/logstash
that referenced
this pull request
Oct 1, 2021
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
karenzone
added a commit
to karenzone/logstash
that referenced
this pull request
Oct 1, 2021
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
karenzone
added a commit
to karenzone/logstash
that referenced
this pull request
Oct 1, 2021
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
This was referenced Oct 1, 2021
karenzone
added a commit
that referenced
this pull request
Oct 1, 2021
Backports #13083 to 7.x Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
karenzone
added a commit
that referenced
this pull request
Oct 1, 2021
Backports #13083 to 7.15 Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
karenzone
added a commit
that referenced
this pull request
Oct 1, 2021
Backports #13083 to 7.14 Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Adds and links shared attribute file for accurately stating ecs default status.
Design intent/usage
We can add/update text related to ecs defaults (or other info we want to write once and use multiple places). Then, we can reference it by calling the attribute. In this case
{ecs-default}.Important: This work requires a corresponding change for the Versioned Plugin Reference.
To do (in this order):
includefile to the Versioned Plugin Reference guide, and test.