[meta] failing plugins specs under master

[colinsurprenant]

Here's the survey of the currently failing specs under master at 066e778

ng-pipeline related failures

devutils pipeline mocking

• pipeline mocking incompatible with ng-pipeline logstash-devutils#42

bad in-specs pipeline mocking

• failing specs under ng-pipeline logstash-plugins/logstash-input-elasticsearch#37
• failing specs under ng-pipeline logstash-plugins/logstash-input-file#86
• failing specs under ng-pipeline logstash-plugins/logstash-input-pipe#12
• failing specs under ng-pipeline logstash-plugins/logstash-input-gelf#31
• failing specs under ng-pipeline logstash-plugins/logstash-input-ganglia#15
• failing specs under ng-pipeline logstash-plugins/logstash-input-generator#12
• failing specs under ng-pipeline logstash-plugins/logstash-input-tcp#36

out-of-order batches?

• failing specs under ng-pipeline logstash-plugins/logstash-output-file#25

unknown origin

I suspect this are actually related to elastic/logstash-devutils#42

hanging specs

• specs are hanging under master logstash-plugins/logstash-input-tcp#37
• specs are hanging under master logstash-plugins/logstash-input-syslog#24

other

• replace awesome_print with amazing_print logstash-plugins/logstash-codec-rubydebug#8
• breaking spec with master related to recent changes in pipeline logstash-plugins/logstash-input-log4j#27

solutions

• short term fix proposal in Better compatibility with specs that depend on output_func monkeypatc… #4373
• real refactor required in refactor specs that depends on implementation dependant pipeline mock #4382

[colinsurprenant]

I just added the devutils pipeline mocking problems issue.

[colinsurprenant]

proposed short-term fix by @andrewvc #4373

[colinsurprenant]

real "long-term" refactor required in #4382

[colinsurprenant]

#4384 solves most issues. updated the description tasks.

[colinsurprenant]

added logstash-plugins/logstash-input-log4j#27 can either @andrewvc or @jsvd take a look? not sure if related to changes introduced by your last pipeline modifications

[colinsurprenant]

log4j fixed by logstash-plugins/logstash-input-log4j#28 thanks @andrewvc

[ph]

@colin Where is this list coming from a local run of a Jenkins job?
This list is different from http://build-eu-00.elasticsearch.org/view/LS%20Master/job/Logstash_Master_Default_Plugins/899/console

[ph]

I have fixed the other issues found from running this job

logstash-plugins/logstash-filter-date#53
logstash-plugins/logstash-output-s3#64

[jsvd]

pr for the rubydebug issue https://github.com/logstash-plugins/logstash-codec-rubydebug/pull/9

[jordansissel]

Looks like most of the items in this check list are now checked. Is it OK to close any tickets that are marked w/ a check here?

[colinsurprenant]

this is all done now for the exception of #4382 which will be dealt with eventually. closing.