-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Remove ability to run multiple subcommands from bin/logstash #1747
Comments
i would love to have this removed. doubt many people actually use it in prod environments. |
For a data point on |
👍 I attempted to use it long ago, but the flakiness had some trouble. In the end, I'm much happier serving Kibana directly from Nginx, and haven't used the web subcommand at all in ages, let alone in a one liner. |
Updated to note that the web subcommand is staying, only that "multiple subcommands being run in the same command line" is proposed for removal |
Yep! Sorry if my wording was ambiguous. |
@torrancew I thought you were clear, but wanted to make sure any onlookers were worried. @colin and @jsvd spent some time this morning trolling me about logstash web :P |
Addresses elastic#1747. This removes the argument list iteration and spawning of multiple tasks. It's still possible to specify aditional arguments but now they're ignored.
Fixed by @jsvd. |
Someone should update this thread: https://logstash.jira.com/browse/LOGSTASH-2267 |
@nehaljwani We are no longer using JIRA as a ticketing system. If you look at the 3 GitHub issues linked in the last comment you'll see some of what we're planning for the future. Future versions of Logstash will be API driven, rather than command-line. This will allow us to have the same kind of functionality you are requesting. Please see our roadmap for more information. |
Today, users can do:
bin/logstash agent -f something.conf -- web
And they'll get a single process with an agent and a web thingy.
I don't think anyone uses this, and it mostly confuses users.
For clarity, I am proposing removing the ability to run multiple 'subcommands' simultaneously. "bin/logstash web" is staying because it is really useful for first-time users, demos, and proof-of-concepts work.
I'd like to remove this function (multiple subprocesses) and in doing so clean up a whole bunch of nasty code in
lib/logstash/runner.rb
.If you depend on this feature, please let me know.
The text was updated successfully, but these errors were encountered: