added safer empty variable checking for windows

elastic · Oct 19, 2023 · 57a0ef9 · 57a0ef9
1 parent 9a25fda
commit 57a0ef9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/bin/setup.bat b/bin/setup.bat
@@ -47,14 +47,14 @@ if not exist "%JAVACMD%" (
 )
 
 rem do not let JAVA_TOOL_OPTIONS slip in (as the JVM does by default)
-if not "%JAVA_TOOL_OPTIONS%" == "" (
+if defined JAVA_TOOL_OPTIONS (
   echo "warning: ignoring JAVA_TOOL_OPTIONS=$JAVA_TOOL_OPTIONS"
   set JAVA_TOOL_OPTIONS=
 )
 
 rem JAVA_OPTS is not a built-in JVM mechanism but some people think it is so we
 rem warn them that we are not observing the value of %JAVA_OPTS%
-if not "%JAVA_OPTS%" == "" (
+if defined JAVA_OPTS (
   echo|set /p="warning: ignoring JAVA_OPTS=%JAVA_OPTS%; "
   echo pass JVM parameters via LS_JAVA_OPTS
 )