Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IPv6 servers #143

Closed
wants to merge 1 commit into from
Closed

Support for IPv6 servers #143

wants to merge 1 commit into from

Conversation

yath
Copy link

@yath yath commented Jan 13, 2014

When a host resolves to an IPv6 address, net.Dial to "addr:port" fails
with "too many colons in address" as the address needs to be enclosed in
square brackets. Use net.JoinHostPort to join them correctly.

Additionally, support square brackets (although not strictly necessary)
in the host specification.

When a host resolves to an IPv6 address, net.Dial to "addr:port" fails
with "too many colons in address" as the address needs to be enclosed in
square brackets. Use net.JoinHostPort to join them correctly.

Additionally, support square brackets (although not strictly necessary)
in the host specification.
@yath
Copy link
Author

yath commented Feb 10, 2014

Uhm, just got around this PR again - the Travis build failure is not in my code, FWIW.

@didebuli
Copy link

didebuli commented Mar 4, 2014

Thank you a lot for this patch!

With IPv6 capable logstash server I was getting "too many colons in address" when a connection to IPv6 was attempted. After applying your patch logstash-forwarder works fine for me with IPv6 and IPv4 addresses.

(Adding square brackets around IP, like fmt.Sprintf("[%s]:%s", address, port) was fix I was using before but this patch is better)

I'm wondering why this simple and straight forward fix was not yet added to master...

@electrical
Copy link

@didebuli we haven't been able to allocate the time we would like to spend on this project :-(
When Logstash 1.4.0 is out the door we will be spending a good amount of time on this to process all the issues and PR's.

Sorry its taking so long :-(

driskell added a commit to driskell/logstash-forwarder that referenced this pull request Mar 19, 2014
@wido
Copy link

wido commented Aug 10, 2014

I would really love to see this be merged in.

I'm setting up a Logstash environment and I want to run on IPv6 only, but currently that's not working out for me with 0.3.1 (from Deb repo)

@jordansissel
Copy link
Contributor

Thanks for helping make logstash-forwarder better!

Logstash-forwarder is going away and is replaced by filebeat and its friend, libbeat. If this is still an issue, would you mind opening a ticket there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants