TEST ONLY - DO NOT MERGE: Validate ECS attr for LSR #1218
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Test set to accompany
elastic/logstash#13427elastic/logstash#13462This PR adds the {ecs-default} attribute to output-elasticsearch.asciidoc to validate that the attribute works as expected.
TEST NOTES
Broken cross-ref. This PR will fail docs CI because the {logstash-ref} attribute used in the default attribute is looking for the
master
branch, which has been renamed tomain
. ToDo: Find out why and fix it.(I'm putting up the PR anyway to have a place to put notes and findings.)
The attribute text also needs to be updated to display link text instead of url.
Here's how the attribute is rendering locally:
I formatted it as a bullet to match the default format for other config options. I might reconsider that.