Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST ONLY - DO NOT MERGE: Validate ECS attr for LSR #1218

Closed
wants to merge 3 commits into from

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Nov 19, 2021

DO NOT MERGE

Test set to accompany elastic/logstash#13427 elastic/logstash#13462
This PR adds the {ecs-default} attribute to output-elasticsearch.asciidoc to validate that the attribute works as expected.

TEST NOTES

  • Broken cross-ref. This PR will fail docs CI because the {logstash-ref} attribute used in the default attribute is looking for the master branch, which has been renamed to main. ToDo: Find out why and fix it.
    (I'm putting up the PR anyway to have a place to put notes and findings.)

  • The attribute text also needs to be updated to display link text instead of url.

  • Here's how the attribute is rendering locally:

    Screen Shot 2021-11-19 at 6 17 47 PM

    I formatted it as a bullet to match the default format for other config options. I might reconsider that.

@karenzone karenzone changed the title TEST ONLY - DO NOT MERGE:: Validate ECS attr for LSR TEST ONLY - DO NOT MERGE: Validate ECS attr for LSR Nov 19, 2021
@karenzone
Copy link
Contributor Author

karenzone commented Nov 19, 2021

I told you docs-ci was going to fail and why. 😉

18:28:33 INFO:build_docs:Bad cross-document links:
18:28:33 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/logstash/master/plugins-outputs-elasticsearch.html contains broken links to:
18:28:33 INFO:build_docs: - en/logstash/master/ls-ecs

@karenzone
Copy link
Contributor Author

karenzone commented Nov 30, 2021

This Test PR will fail docs-ci until #13462 is merged.

@karenzone
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant