[TSVB] Timeseries Drop last bucket set default to false #97257

DianaDerevyankina · 2021-04-15T14:07:56Z

Closes #95756

Summary

Changed the default value of Drop last bucket setting to false.
Added a tooltip indicating there's partial data. It's displayed for the last value in case the last bucket is not dropped either for the whole visualization or for any series. (To test that last bucket should intersect the time selector)

To drop last bucket for the series: Data -> Options select "Yes" for Override Index Pattern? and then Drop last bucket

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

alexwizp · 2021-04-16T07:43:18Z

src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js

  series,
  yAxis,
  onBrush,
  xAxisFormatter,
  annotations,
  syncColors,
  palettesService,
+  interval,
+  shouldDropLastBucket,


In fact, the drop bucket happens on the server side. I think the name of the variable does not reflect the essence of what you want. Please rename

alexwizp · 2021-04-16T07:50:02Z

@elasticmachine merge upstream

alexwizp · 2021-04-16T08:52:34Z

src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/vis.js

            xAxisFormatter={this.xAxisFormatter(interval)}
            annotations={this.prepareAnnotations()}
            syncColors={syncColors}
            palettesService={palettesService}
+            interval={interval}
+            shouldDropLastBucket={Boolean(


I think user should see that message if DropLastBucket is false =)

alexwizp · 2021-04-16T09:09:16Z

src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js

+      ? renderEndzoneTooltip(
+          interval,
+          seriesData[0][0],
+          seriesData[seriesData.length - 1][0],


please extract logic for getting domain into a separate method

const caclulateDomainForSeries = (series) => { const seriesData = series[0]?.data || []; return { domainStart: seriesData[0][0], domainEnd: seriesData[Math.max(seriesData.length - 1, 0)][0], }; }; export const TimeSeries = ({ .....

and then

let tooltipFormatter; if (shouldDropLastBucket) { const { domainStart, domainEnd } = caclulateDomainForSeries(series); tooltipFormatter = renderEndzoneTooltip( interval, domainStart, domainEnd, decorateFormatter(xAxisFormatter) ); } else { tooltipFormatter = decorateFormatter(xAxisFormatter); }

… a separate file

DianaDerevyankina · 2021-04-16T11:32:32Z

@elasticmachine merge upstream

alexwizp · 2021-04-16T12:14:42Z

@stratoula @dziyanadzeraviankina I think we should also update our sample visualizations.

stratoula · 2021-04-16T12:18:53Z

I was going to create an issue for that 🙂

DianaDerevyankina · 2021-04-19T05:11:49Z

@elasticmachine merge upstream

alexwizp · 2021-04-20T08:13:34Z

@elasticmachine merge upstream

alexwizp · 2021-04-20T11:31:56Z

...ugins/vis_type_timeseries/server/lib/vis_data/response_processors/series/drop_last_bucket.js

@@ -14,7 +14,7 @@ export function dropLastBucket(resp, panel, series) {
    const shouldDropLastBucket = isLastValueTimerangeMode(panel, series);

    if (shouldDropLastBucket) {
-      const seriesDropLastBucket = get(series, 'override_drop_last_bucket', 1);
+      const seriesDropLastBucket = get(series, 'override_drop_last_bucket', 0);


I think the following code works wrong, override_drop_last_bucket should has a priority todrop_last_bucket

// wrong code const seriesDropLastBucket = get(series, 'override_drop_last_bucket', 0); const dropLastBucket = get(panel, 'drop_last_bucket', seriesDropLastBucket);

@dziyanadzeraviankina @stratoula think we can that in scope of that PR

alexwizp · 2021-04-22T13:37:38Z

.../public/application/visualizations/views/timeseries/utils/series_domain_calculations.test.ts

+    expect(domainBounds?.domainStart).toBeUndefined();
+    expect(domainBounds?.domainEnd).toBeUndefined();


Suggested change

expect(domainBounds?.domainStart).toBeUndefined();

expect(domainBounds?.domainEnd).toBeUndefined();

expect(domainBounds).toBeUndefined();

…ibana into issues/95756

dimaanj

LGTM, tested it locally

VladLasitsa

LGTM

alexwizp

LGTM

elasticmachine · 2021-04-23T07:20:26Z

Pinging @elastic/kibana-app (Team:KibanaApp)

wylieconlon

This PR introduces a bug in the tooltip. When the last bucket is kept, the tooltip only shows the current time. Steps to reproduce:

Install the ecommerce data
Go to the ecommerce dashboard
Hover over the TSVB chart with annotations

timroes · 2021-04-27T07:10:50Z

@elasticmachine run elasticsearch-ci/docs

wylieconlon

LGTM!

DianaDerevyankina · 2021-04-30T06:36:52Z

@elasticmachine merge upstream

kibanamachine · 2021-04-30T08:34:41Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visTypeTimeseries`	501	502	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeTimeseries`	1.7MB	1.7MB	+724.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visTypeTimeseries`	25.3KB	25.5KB	+252.0B

History

💚 Build #122451 succeeded 15048f1
💚 Build #122395 succeeded a160c45
💚 Build #121723 succeeded 46cc8e3
💚 Build #121717 succeeded 3064714
💚 Build #121376 succeeded 7099e4d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

timroes · 2021-04-30T08:36:07Z

@elasticmachine run elasticsearch-ci/docs

* [TSVB] Timeseries Drop last bucket should default to false * Rename isLastBucketDropped prop and move series domain calculation to a separate file * Fix failing tests because of wrong default value * update drop_last_bucket.js * Refactor drop_last_bucket and some functional tests * Change infra metrics test values because of last bucket value changed * Refactor series_domain_calculation and related code * Update series_domain_calculations.test * Update series_domain_calculations.test * Fix tooltip showing wrong time * Refactor index Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

) * [TSVB] Timeseries Drop last bucket should default to false * Rename isLastBucketDropped prop and move series domain calculation to a separate file * Fix failing tests because of wrong default value * update drop_last_bucket.js * Refactor drop_last_bucket and some functional tests * Change infra metrics test values because of last bucket value changed * Refactor series_domain_calculation and related code * Update series_domain_calculations.test * Update series_domain_calculations.test * Fix tooltip showing wrong time * Refactor index Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

[TSVB] Timeseries Drop last bucket should default to false

a3df9c0

DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 15, 2021

DianaDerevyankina requested review from VladLasitsa and alexwizp April 15, 2021 14:07

DianaDerevyankina self-assigned this Apr 15, 2021

alexwizp reviewed Apr 16, 2021

View reviewed changes

Merge branch 'master' into issues/95756

624e1a0

alexwizp reviewed Apr 16, 2021

View reviewed changes

Rename isLastBucketDropped prop and move series domain calculation to…

c7749f4

… a separate file

Merge branch 'master' into issues/95756

b9f9b9b

kibanamachine and others added 3 commits April 19, 2021 01:11

Merge branch 'master' into issues/95756

e2b0bd0

Merge branch 'master' into issues/95756

3e614b5

Fix failing tests because of wrong default value

f9b2f3d

kibanamachine and others added 2 commits April 20, 2021 04:13

Merge branch 'master' into issues/95756

84ee389

update drop_last_bucket.js

bb1b7ec

alexwizp reviewed Apr 20, 2021

View reviewed changes

DianaDerevyankina added 2 commits April 21, 2021 10:40

Refactor drop_last_bucket and some functional tests

a2e7fcc

Change infra metrics test values because of last bucket value changed

7099e4d

spalger added the v7.14.0 label Apr 21, 2021

Refactor series_domain_calculation and related code

3064714

alexwizp reviewed Apr 22, 2021

View reviewed changes

DianaDerevyankina added 3 commits April 22, 2021 16:42

Update series_domain_calculations.test

1e62d9f

Update series_domain_calculations.test

d05be47

Merge branch 'issues/95756' of https://github.com/DianaDerevyankina/k…

46cc8e3

…ibana into issues/95756

dimaanj approved these changes Apr 22, 2021

View reviewed changes

VladLasitsa approved these changes Apr 22, 2021

View reviewed changes

alexwizp approved these changes Apr 23, 2021

View reviewed changes

alexwizp marked this pull request as ready for review April 23, 2021 07:20

alexwizp requested a review from a team April 23, 2021 07:20

wylieconlon suggested changes Apr 23, 2021

View reviewed changes

DianaDerevyankina added 3 commits April 26, 2021 13:14

Merge branch 'master' into issues/95756

c11e3ca

Fix tooltip showing wrong time

a160c45

Refactor index

15048f1

DianaDerevyankina requested a review from wylieconlon April 27, 2021 07:12

wylieconlon approved these changes Apr 29, 2021

View reviewed changes

Merge branch 'master' into issues/95756

9dc60a8

DianaDerevyankina merged commit 6b6ad11 into elastic:master Apr 30, 2021

DianaDerevyankina mentioned this pull request Apr 30, 2021

[7.x] [TSVB] Timeseries Drop last bucket set default to false (#97257) #98879

Merged

alexwizp mentioned this pull request May 7, 2021

[DOCS] Adds dual mode to TSVB #99493

Merged

alexwizp mentioned this pull request Sep 1, 2021

[TSVB] Add migration script for 'drop_last_bucket' value #110782

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Timeseries Drop last bucket set default to false #97257

[TSVB] Timeseries Drop last bucket set default to false #97257

DianaDerevyankina commented Apr 15, 2021 •

edited

Loading

alexwizp Apr 16, 2021

alexwizp commented Apr 16, 2021

alexwizp Apr 16, 2021

alexwizp Apr 16, 2021

alexwizp Apr 16, 2021

DianaDerevyankina commented Apr 16, 2021

alexwizp commented Apr 16, 2021

stratoula commented Apr 16, 2021

DianaDerevyankina commented Apr 19, 2021

alexwizp commented Apr 20, 2021

alexwizp Apr 20, 2021 •

edited

Loading

alexwizp Apr 22, 2021

dimaanj left a comment

VladLasitsa left a comment

alexwizp left a comment

elasticmachine commented Apr 23, 2021

wylieconlon left a comment

timroes commented Apr 27, 2021

wylieconlon left a comment

DianaDerevyankina commented Apr 30, 2021

kibanamachine commented Apr 30, 2021

timroes commented Apr 30, 2021

		expect(domainBounds?.domainStart).toBeUndefined();
		expect(domainBounds?.domainEnd).toBeUndefined();

	expect(domainBounds?.domainStart).toBeUndefined();
	expect(domainBounds?.domainEnd).toBeUndefined();
	expect(domainBounds).toBeUndefined();

[TSVB] Timeseries Drop last bucket set default to false #97257

[TSVB] Timeseries Drop last bucket set default to false #97257

Conversation

DianaDerevyankina commented Apr 15, 2021 • edited Loading

Summary

Checklist

For maintainers

alexwizp Apr 16, 2021

Choose a reason for hiding this comment

alexwizp commented Apr 16, 2021

alexwizp Apr 16, 2021

Choose a reason for hiding this comment

alexwizp Apr 16, 2021

Choose a reason for hiding this comment

alexwizp Apr 16, 2021

Choose a reason for hiding this comment

DianaDerevyankina commented Apr 16, 2021

alexwizp commented Apr 16, 2021

stratoula commented Apr 16, 2021

DianaDerevyankina commented Apr 19, 2021

alexwizp commented Apr 20, 2021

alexwizp Apr 20, 2021 • edited Loading

Choose a reason for hiding this comment

alexwizp Apr 22, 2021

Choose a reason for hiding this comment

dimaanj left a comment

Choose a reason for hiding this comment

VladLasitsa left a comment

Choose a reason for hiding this comment

alexwizp left a comment

Choose a reason for hiding this comment

elasticmachine commented Apr 23, 2021

wylieconlon left a comment

Choose a reason for hiding this comment

timroes commented Apr 27, 2021

wylieconlon left a comment

Choose a reason for hiding this comment

DianaDerevyankina commented Apr 30, 2021

kibanamachine commented Apr 30, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

timroes commented Apr 30, 2021

DianaDerevyankina commented Apr 15, 2021 •

edited

Loading

alexwizp Apr 20, 2021 •

edited

Loading