Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error switching index patterns in Discover #9682

Merged
merged 1 commit into from
Jan 3, 2017
Merged

Fix error switching index patterns in Discover #9682

merged 1 commit into from
Jan 3, 2017

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Dec 29, 2016

Needed to cleanup debounced function on scope destory.

Fixes #9681
Caused by #9326

@Bargs
Fix error switching index patterns in Discover
f82624f 
Needed to cleanup debounced function on scope destory.

Fixes elastic#9681
lukasolson
lukasolson approved these changes Dec 29, 2016
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

weltenwort
weltenwort approved these changes Jan 2, 2017
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bargs Bargs merged commit 504db45 into elastic:master Jan 3, 2017
@elastic-jasper elastic-jasper mentioned this pull request Jan 3, 2017
Merged
elastic-jasper added a commit that referenced this pull request Jan 3, 2017
@elastic-jasper
Fix error switching index patterns in Discover
bba89c3 
Backports PR #9682

**Commit 1:**
Fix error switching index patterns in Discover

Needed to cleanup debounced function on scope destory.

Fixes #9681

* Original sha: f82624f
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-12-29T22:29:40Z
Bargs pushed a commit that referenced this pull request Jan 3, 2017
@elastic-jasper @Bargs
Fix error switching index patterns in Discover (#9705)
b2ffc35 
Backports PR #9682

**Commit 1:**
Fix error switching index patterns in Discover

Needed to cleanup debounced function on scope destory.

Fixes #9681

* Original sha: f82624f
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-12-29T22:29:40Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

@lukasolson lukasolson lukasolson approved these changes

Assignees

@weltenwort weltenwort

@lukasolson lukasolson

Labels
review v5.2.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bargs @weltenwort @lukasolson