Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unskip accessibility - dashboard_edit_panel tests #96710

Merged
merged 9 commits into from
Apr 14, 2021
Merged

unskip accessibility - dashboard_edit_panel tests #96710

merged 9 commits into from
Apr 14, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

Fixes: #92114

Ran this test locally many times successfully hence trying to unskip and check.

@rashmivkulkarni rashmivkulkarni self-assigned this Apr 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rudolf
Copy link
Contributor

rudolf commented Apr 12, 2021

Test failure seems is caused by a flaky test that we re-enabled today and unrelated to your changes.

@rashmivkulkarni
Copy link
Contributor Author

This PR is failing not 'cos of any change in this skipped test. Has a Jest failure
@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@LeeDr / @myasonik - couldn't reproduce the error reported when this test was skipped.Passed locally many times, and on Jenkins too this test is passing. But has a unrelated JEST failure. @rudolf opines that its safe to merge still.

@myasonik
Copy link
Contributor

Sure, if it's an unrelated flaky test failure, I don't see why we shouldn't merge this.

@LeeDr
Copy link

LeeDr commented Apr 13, 2021

Please run the flaky test runner 50 times on it

@rashmivkulkarni
Copy link
Contributor Author

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1449/ - 50 executions of this test passed on Flaky Test Runner

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

@rashmivkulkarni
Copy link
Contributor Author

https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1453/ ( Flaky test runner - successful- 50 times)

LeeDr
LeeDr approved these changes Apr 14, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Code reviewed and good test results

@rashmivkulkarni rashmivkulkarni merged commit 3ba6404 into elastic:master Apr 14, 2021
@rashmivkulkarni rashmivkulkarni mentioned this pull request Apr 14, 2021
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Apr 14, 2021
@rashmivkulkarni @kibanamachine
unskip accessibility - dashboard_edit_panel tests (elastic#96710)
aa6426c 
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rashmivkulkarni added a commit that referenced this pull request Apr 15, 2021
@rashmivkulkarni @kibanamachine
unskip accessibility - dashboard_edit_panel tests (#96710) (#97192)
34965c5 
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@rashmivkulkarni @elasticmachine @rudolf @myasonik @LeeDr @kibanamachine