Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kbn-ui-shared-deps] Remove outdated polyfills #96339

Merged
merged 6 commits into from
Apr 8, 2021
Merged

[kbn-ui-shared-deps] Remove outdated polyfills #96339

merged 6 commits into from
Apr 8, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Apr 6, 2021 •
edited
Loading

These polyfills should be covered by our browser
support matrix now that IE11 has been removed.

https://caniuse.com/childnode-remove
https://caniuse.com/abortcontroller
https://caniuse.com/customevent
https://www.elastic.co/support/matrix#matrix_browsers

Part of #91329

@jbudz jbudz added the Team:Operations Team label for Operations Team label Apr 6, 2021
@jbudz jbudz changed the title [kbn-ui-shared-deps] Remove AbortController and ChildNode.Removepolyfills [kbn-ui-shared-deps] Remove outdated polyfills Apr 6, 2021
@jbudz jbudz marked this pull request as ready for review April 7, 2021 18:31
@jbudz jbudz requested a review from a team as a code owner April 7, 2021 18:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz added the release_note:skip Skip the PR/issue when compiling release notes label Apr 7, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-elastic 3.3MB 3.3MB -3.0B
kbnUiSharedDeps-js 6.7MB 6.7MB -5.6KB
total -5.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger
spalger approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed that all these polyfills were only needed for IE via MDN

@jbudz jbudz added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 8, 2021
@jbudz jbudz merged commit 02ba7c4 into elastic:master Apr 8, 2021
@jbudz jbudz deleted the kbn-ui-shared-deps/polyfills branch April 8, 2021 13:49
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.x: Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 96339

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96339 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 12, 2021
jbudz added a commit that referenced this pull request Apr 12, 2021
@jbudz
[kbn-ui-shared-deps] Remove outdated polyfills (#96339)
b0a2b23
@jbudz
Copy link
Member Author

jbudz commented Apr 12, 2021

7.x: b0a2b23

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 12, 2021
@jbudz jbudz mentioned this pull request Apr 12, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbudz @elasticmachine @kibanamachine @spalger