-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a notice about the port to access Kibana. #9622
Conversation
Can one of the admins verify this patch? |
jenkins, test this |
@jgbarah Thanks for resubmitting! I have a suggestion for new phrasing after the first sentence:
|
Thanks for the quick review. I just amended the commit with the sentence you suggested. |
@@ -140,6 +140,8 @@ Start the development server. | |||
npm start | |||
``` | |||
|
|||
> Now you can point your web browser to https://localhost:5601 and start using Kibana! When running `npm start`, Kibana will also log that it is listening on port 5603 due to the base path proxy, but you should still access Kibana on port 5601. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing (sorry if I missed this in the previous review): I think this paragraph should go after the "> On Windows, ..." paragraph, and it should not include a >
so it appears as normal text. So it would look like this:
This way the "on windows" thing is still explaining a needs for running the previous command, whereas the new text is simply explaining what's next.
I understand, and I agree this is better. New version committed. |
jenkins, test this |
Thanks for this! |
This is an updated version of #7303. I'm sorry I had not noticed about the last comments by the reviewer. I rebased the commit, changed its insertion point, and changed the text to the suggested one.