Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY_SOLUTION] Adds hash validation on UI for trusted app #94958

Merged
merged 4 commits into from
Mar 22, 2021
Merged

[SECURITY_SOLUTION] Adds hash validation on UI for trusted app #94958

merged 4 commits into from
Mar 22, 2021

Conversation

dasansol92
Copy link
Contributor

@dasansol92 dasansol92 commented Mar 18, 2021 •
edited
Loading

Summary

  • The hash validation is done on the frontend side preventing users submit invalid hash values. It uses the same function that is used on the BE validation.
  • Also fixes an issue when checking errors, only the first one was detected. Now it displays as many errors as there are.
  • Updates and added unit test cases.

hash validation on FE

Checklist

For maintainers

@dasansol92
Adds hash validation on UI. Display as many error messages as they ar…
2805afe 
…e instead of displaying just the first one on entry fields. Updates related unit test
@dasansol92 dasansol92 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.13.0 labels Mar 18, 2021
@dasansol92 dasansol92 requested a review from a team as a code owner March 18, 2021 17:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2203 2204 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.2MB 7.2MB +460.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dasansol92 dasansol92 merged commit 7270f6d into elastic:master Mar 22, 2021
dasansol92 added a commit to dasansol92/kibana that referenced this pull request Mar 22, 2021
@dasansol92 @kibanamachine
[SECURITY_SOLUTION] Adds hash validation on UI for trusted app (elast…
d238696 
…ic#94958)

* Adds hash validation on UI. Display as many error messages as they are instead of displaying just the first one on entry fields. Updates related unit test

* Fixes failing test and added new test case

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dasansol92 dasansol92 mentioned this pull request Mar 22, 2021
Merged
stephmilovic pushed a commit that referenced this pull request Mar 22, 2021
@dasansol92 @kibanamachine @stephmilovic
[SECURITY_SOLUTION] Adds hash validation on UI for trusted app (#94958)
9ad1b49 
* Adds hash validation on UI. Display as many error messages as they are instead of displaying just the first one on entry fields. Updates related unit test

* Fixes failing test and added new test case

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dasansol92 added a commit that referenced this pull request Mar 22, 2021
@dasansol92 @kibanamachine
[SECURITY_SOLUTION] Adds hash validation on UI for trusted app (#94958)…
7ebee0f 
… (#95080)

* Adds hash validation on UI. Display as many error messages as they are instead of displaying just the first one on entry fields. Updates related unit test

* Fixes failing test and added new test case

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzl pzl pzl approved these changes

@parkiino parkiino parkiino approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dasansol92 @elasticmachine @kibanamachine @pzl @parkiino