Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Support force flag in bulk upgrade agents API #94952

Merged
merged 4 commits into from
Mar 23, 2021

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Mar 18, 2021

Summary

0cbbb41 is just a rearrangement of the tests. 5cad301 has the real changes:

Checklist

@jfsiii jfsiii changed the title [WIP][Fleet] change bulk upgrade agents API response [Fleet] Support force flag in bulk upgrade agents API Mar 18, 2021
@jfsiii jfsiii marked this pull request as ready for review March 18, 2021 19:17
@jfsiii jfsiii requested a review from a team as a code owner March 18, 2021 19:17
@jfsiii jfsiii requested review from nchaulet and jen-huang March 18, 2021 19:17
@jfsiii jfsiii added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0 labels Mar 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@jfsiii jfsiii added Team:Fleet Team label for Observability Data Collection Fleet team and removed Feature:Fleet Fleet team's agent central management project labels Mar 18, 2021
@jfsiii jfsiii enabled auto-merge (squash) March 18, 2021 21:21
@jfsiii jfsiii self-assigned this Mar 18, 2021
@jfsiii
Copy link
Contributor Author

jfsiii commented Mar 21, 2021

@elasticmachine merge upstream

@jfsiii
Copy link
Contributor Author

jfsiii commented Mar 23, 2021

@elasticmachine merge upstream

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jfsiii

@jfsiii jfsiii merged commit c0c5fba into elastic:master Mar 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 23, 2021
## Summary

elastic@0cbbb41 is just a rearrangement of the tests.  elastic@5cad301 has the real changes: 
* Bug fix: `force: true` should bypass any restrictions re: managed policies
* Refactoring towards new response shape coming as part of elastic#90437
* Added test to confirm new behavior


### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #95181

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 23, 2021
## Summary

0cbbb41 is just a rearrangement of the tests.  5cad301 has the real changes: 
* Bug fix: `force: true` should bypass any restrictions re: managed policies
* Refactoring towards new response shape coming as part of #90437
* Added test to confirm new behavior


### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: John Schulz <john.schulz@elastic.co>
@jfsiii jfsiii deleted the bulk-upgrade-should-not-error branch April 6, 2021 17:08
@dikshachauhan-qasource
Copy link

Hi @jfsiii

We have validated bulk actions behavior on managed hosts on 8.0 snapshot build environment.

Currently, we are unable to test managed hosts with force flag as checkbox for them is already disabled.
image

So could you please confirm us how we can verify above merge. Please API as well.

cc @EricDavisX

Thanks
QAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants