[Canvas] Cleanup types in lib #94517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
mshustov
commented
Mar 12, 2021
| image: resolveWithMissingImage(args.image, elasticOutline), | ||
| emptyImage: resolveWithMissingImage(args.emptyImage), | ||
| image: resolveWithMissingImage(args.image, elasticOutline) as string, | ||
| emptyImage: resolveWithMissingImage(args.emptyImage) as string, |
There was a problem hiding this comment.
probably resolveWithMissingImage should return strings only instead of string | null? I left the current behavior since it's to be desirable according to the unit tests.
There was a problem hiding this comment.
Agree, that should be cleaned up.
crob611
approved these changes
Mar 16, 2021
| @@ -52,7 +50,7 @@ export interface CanvasRenderable { | |||
| state: 'ready' | 'error'; | |||
| value: { | |||
| as: string; | |||
| containerStyle: ContainerStyle; | |||
| containerStyle: any; | |||
There was a problem hiding this comment.
Is this ContainerStyle type not importable from somewhere?
There was a problem hiding this comment.
the comment says // @ts-expect-error Unlinked Webpack Type. No idea what it means, but tsc uses any instead
| image: resolveWithMissingImage(args.image, elasticOutline), | ||
| emptyImage: resolveWithMissingImage(args.emptyImage), | ||
| image: resolveWithMissingImage(args.image, elasticOutline) as string, | ||
| emptyImage: resolveWithMissingImage(args.emptyImage) as string, |
There was a problem hiding this comment.
Agree, that should be cleaned up.
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 16, 2021
* fix get_legend_config error in canvas/lib/index * convert resolve_dataurl to ts to fix canvas/lib/index failure * convert expression_form_handler to ts to fix canvas/lib/index failure * convert canvas lib/error into ts * canvas: do not compile json file due to effect on performance * remove type. it is not exported and inferred as any implicitly * fix datatable error in lib/index.d.ts file * fix url resolver * case manually to avoid incompatibility error
kibanamachine
added a commit
that referenced
this pull request
Mar 16, 2021
* fix get_legend_config error in canvas/lib/index * convert resolve_dataurl to ts to fix canvas/lib/index failure * convert expression_form_handler to ts to fix canvas/lib/index failure * convert canvas lib/error into ts * canvas: do not compile json file due to effect on performance * remove type. it is not exported and inferred as any implicitly * fix datatable error in lib/index.d.ts file * fix url resolver * case manually to avoid incompatibility error Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #92175
Fixes TS errors in Canvas code that start failing when tests import generated
d.tsfiles.