Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use documentation link service for remote clusters #93937

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Use documentation link service for remote clusters #93937

merged 6 commits into from
Mar 15, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Mar 8, 2021 •
edited
Loading

Summary

Relates to #88107

This PR replaces hard-coded links with keywords from the documentation link service.

Screenshot

The links are used in the Remote Clusters UI in places like this:

Screen Shot 2021-03-06 at 1 18 41 PM

@jrodewig jrodewig mentioned this pull request Mar 8, 2021
Closed
@jrodewig
Copy link
Contributor Author

jrodewig commented Mar 8, 2021

@elasticmachine merge upstream

@jrodewig jrodewig marked this pull request as ready for review March 9, 2021 13:30
@jrodewig jrodewig requested review from a team as code owners March 9, 2021 13:30
TinaHeiligers
TinaHeiligers approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

@jrodewig
Copy link
Contributor Author

@elasticmachine merge upstream

@jrodewig
Copy link
Contributor Author

@elasticmachine merge upstream

@jrodewig
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 432.1KB 432.2KB +110.0B
remoteClusters 15.6KB 15.4KB -270.0B
total -160.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring those documentation links, @jrodewig! Code changes LGTM 👍

@jrodewig jrodewig merged commit cd56c13 into elastic:master Mar 15, 2021
@jrodewig jrodewig deleted the docs__remote-clusters-doc-links branch March 15, 2021 18:02
@jrodewig jrodewig mentioned this pull request Mar 15, 2021
Merged
jrodewig added a commit that referenced this pull request Mar 15, 2021
@jrodewig
Use documentation link service for remote clusters (#93937) (#94622)
9fd4133
@marius-dr marius-dr mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
docs Feature:CCR and Remote Clusters Feature:Cross Cluster Search release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrodewig @kibanamachine @yuliacech @TinaHeiligers