Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting][Docs] Moving limitations from README to user docs #93933

Merged
merged 4 commits into from
Mar 8, 2021
Merged

[Alerting][Docs] Moving limitations from README to user docs #93933

merged 4 commits into from
Mar 8, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Mar 8, 2021 •
edited
Loading

Addresses one part of #89999

Summary

Removed outdated limitations section from alerting README

@ymao1 ymao1 mentioned this pull request Mar 8, 2021
Closed
5 tasks
@ymao1 ymao1 self-assigned this Mar 8, 2021
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v7.13.0 v8.0.0 labels Mar 8, 2021
@ymao1 ymao1 marked this pull request as ready for review March 8, 2021 14:05
@ymao1 ymao1 requested a review from a team as a code owner March 8, 2021 14:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 requested a review from gchaps March 8, 2021 14:05
YulNaumenko
YulNaumenko approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikecote
mikecote reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing we are formalizing these. The manage_api_key and manage_own_api_key requirement is no longer a thing (it used to be back in 7.7 or so) so we're good to cleanup the README and not have them in asciidoc. I'm not sure if there are any other new limitations of interest we should document? 🤔

@ymao1
Copy link
Contributor Author

ymao1 commented Mar 8, 2021

Good thing we are formalizing these. The manage_api_key and manage_own_api_key requirement is no longer a thing (it used to be back in 7.7 or so) so we're good to cleanup the README and not have them in asciidoc. I'm not sure if there are any other new limitations of interest we should document? 🤔

Good to know! I will remove them altogether then.

@ymao1 ymao1 removed the request for review from gchaps March 8, 2021 14:51
pmuellr
pmuellr approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gchaps
gchaps approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

mikecote
mikecote approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 8, 2021
@ymao1 ymao1 merged commit 8a1d7f5 into elastic:master Mar 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 8, 2021
@ymao1 @kibanamachine
[Alerting][Docs] Moving limitations from README to user docs (elastic…
a020329 
…#93933)

* Moving limitations to user docs

* Moving limitations to user docs

* Removing outdated limitations
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2021
Merged
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 8, 2021
@ymao1 @kibanamachine
[Alerting][Docs] Moving limitations from README to user docs (elastic…
7f77f21 
…#93933)

* Moving limitations to user docs

* Moving limitations to user docs

* Removing outdated limitations
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #93978
✅ 7.x / #93979

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 8, 2021
@kibanamachine @ymao1
[Alerting][Docs] Moving limitations from README to user docs (#93933) (…
ec2dedb 
…#93978)

* Moving limitations to user docs

* Moving limitations to user docs

* Removing outdated limitations

Co-authored-by: ymao1 <ying.mao@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 8, 2021
@kibanamachine @ymao1
[Alerting][Docs] Moving limitations from README to user docs (#93933) (…
8d57425 
…#93979)

* Moving limitations to user docs

* Moving limitations to user docs

* Removing outdated limitations

Co-authored-by: ymao1 <ying.mao@elastic.co>
@ymao1 ymao1 deleted the alerting/limitations branch March 25, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@mikecote mikecote mikecote approved these changes

@gchaps gchaps gchaps approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@ymao1 ymao1

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ymao1 @elasticmachine @kibanamachine @pmuellr @mikecote @gchaps @YulNaumenko