Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] TSVB updates for 7.12 #93317

Merged
merged 10 commits into from
Mar 15, 2021
Merged

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Mar 2, 2021

Summary

This PR updates the TSVB page with the following:

  • Reformats the embedded task information into ordered lists.
  • Applies bold to UI options.
  • Reorganizes the FAQ so that the supported questions appear before the unsupported questions.

@KOTungseth KOTungseth added v7.12.0 v7.13.0 release_note:skip Skip the PR/issue when compiling release notes Team:Docs labels Mar 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple tweaks!

How do I calculate the duration between start and end of an event?::
TSVB can't do this because it requires correlation between different time periods. TSVB requires
that the duration is pre-calculated.
For answers to frequently asked *TSVB* question, review the following.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sentence necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the content necessary? No. But Asciidoc requires some sort of wording to separate titles.


TIP: With *TSVB*, you can visualize the data from multiple series, but only *Timelion* can perform math across layers.
*TSVB* enables you to visualize the data from multiple data series, supports <<aggregation-reference,
most {es} metric aggregations>>, multiple visualization types, custom functions, and some math. To use *TSVB*, you must have a date field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must have a date field > your data must have a date field?

Is it date field or time field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is content that Wylie wrote, so I was hoping he would have commented. Since he is out this week, I'm going to leave it, but I'll make a note to follow up for the 7.13 release.

KOTungseth and others added 5 commits March 15, 2021 09:21
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
@KOTungseth KOTungseth merged commit ae1f284 into elastic:master Mar 15, 2021
@KOTungseth KOTungseth deleted the docs/tsvb-7.12 branch March 15, 2021 14:48
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 15, 2021
* [DOCS] TSVB updates for 7.12

* Fixes formatting

* Clean up

* Review comments

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Review comments

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 15, 2021
* [DOCS] TSVB updates for 7.12

* Fixes formatting

* Clean up

* Review comments

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Review comments

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
KOTungseth added a commit that referenced this pull request Mar 15, 2021
* [DOCS] TSVB updates for 7.12

* Fixes formatting

* Clean up

* Review comments

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Review comments

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
KOTungseth added a commit that referenced this pull request Mar 15, 2021
* [DOCS] TSVB updates for 7.12

* Fixes formatting

* Clean up

* Review comments

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Review comments

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.0 v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants