[APM] Guard searches with range/additional queries #92112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine merge upstream |
smith
approved these changes
Feb 22, 2021
| filter: [{ range: { [OBSERVER_VERSION_MAJOR]: { lt: 7 } } }], | ||
| filter: [ | ||
| { range: { [OBSERVER_VERSION_MAJOR]: { lt: 7 } } }, | ||
| ...rangeQuery(setup.start, setup.end), |
There was a problem hiding this comment.
Can we destructure these from setup above? Doesn't matter but it's done consistently everywhere else.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 23, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85385.
The following changes were made:
@timestamp, use sort. This is faster (based on limited testing)existsqueries to the breakdown search, to only include transaction/span breakdown metric documents. We use sum aggregations on fields only available to those documents, so the result is correct even when other metric documents are included. However, ES still needs to aggregate over the documents that we don't care about.