Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Lazy ml node UI improvements #90455

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 5, 2021

Fixes items listed in #90196

New job wizard for recognised indices.
When the module setup endpoint returns that some jobs are awaiting node allocation, a callout is displayed at the top and a warning icon shown for each datafeed which is waiting to start.
image

Checklist

Delete any items that are not applicable to this PR.

@jgowdyelastic jgowdyelastic marked this pull request as ready for review February 5, 2021 17:03
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 5, 2021 17:03
@jgowdyelastic jgowdyelastic self-assigned this Feb 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@lcawl
Copy link
Contributor

lcawl commented Feb 9, 2021

Related to #90051 (comment), if the ... x jobs waiting to be started while ML nodes are being provisioned message in jobs_awaiting_node_warning.tsx can also appear in non-Cloud environments, can we use a term other than "provisioned", since that seems to be Cloud-specific terminology? Something along the lines of "...x jobs waiting for machine learning nodes to start"?

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.3MB 6.3MB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 3d068c5 into elastic:master Feb 9, 2021
@jgowdyelastic jgowdyelastic deleted the ml-lazy-node-improvements branch February 9, 2021 15:03
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 9, 2021
* [ML] Lazy ml node UI improvements

* fixing test

* adding awaitingMlNodeAllocation to default datafeed response

* changing datafeed icon when node is not assigned

* updating text

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jgowdyelastic added a commit that referenced this pull request Feb 10, 2021
* [ML] Lazy ml node UI improvements

* fixing test

* adding awaitingMlNodeAllocation to default datafeed response

* changing datafeed icon when node is not assigned

* updating text

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 11, 2021
* [ML] Lazy ml node UI improvements

* fixing test

* adding awaitingMlNodeAllocation to default datafeed response

* changing datafeed icon when node is not assigned

* updating text

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jgowdyelastic added a commit that referenced this pull request Feb 11, 2021
* [ML] Lazy ml node UI improvements

* fixing test

* adding awaitingMlNodeAllocation to default datafeed response

* changing datafeed icon when node is not assigned

* updating text

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants