Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dark theme when leaving the Dashboard app. Add dark theme for localNav. #9032

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Remove dark theme when leaving the Dashboard app. Add dark theme for localNav. #9032

merged 2 commits into from
Nov 11, 2016

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Nov 10, 2016 •
edited
Loading

Addresses #8925 and #9030
Forward-ports a bugfix commit from #8941

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience release_note:enhancement labels Nov 10, 2016
@cjcenizal cjcenizal changed the title Remove dark theme when leaving the Dashboard app. Remove dark theme when leaving the Dashboard app. Add dark theme for localNav. Nov 10, 2016
@cjcenizal cjcenizal added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 10, 2016
@ppisljar
Copy link
Member

LGTM

@alt74
Copy link

alt74 commented Nov 11, 2016

@cjcenizal LGTM

@cjcenizal cjcenizal merged commit deec2eb into elastic:master Nov 11, 2016
@cjcenizal cjcenizal deleted the 8925/5.x/bug/share-ui-dark-theme branch November 11, 2016 20:58
@cjcenizal cjcenizal mentioned this pull request Nov 11, 2016
Closed
elastic-jasper added a commit that referenced this pull request Nov 11, 2016
@elastic-jasper
Remove dark theme when leaving the Dashboard app. Add dark theme for …
29bab2d 
…localNav.

Backports PR #9032

**Commit 1:**
Remove dark theme when leaving the Dashboard app.

* Original sha: 700f750
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-10T19:40:34Z

**Commit 2:**
Upgrade kibana-ui-framework to 0.0.10: localNav dark theme styles.

* Original sha: c339694
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-10T19:48:10Z
@elastic-jasper elastic-jasper mentioned this pull request Nov 11, 2016
Merged
cjcenizal pushed a commit that referenced this pull request Nov 11, 2016
@elastic-jasper @cjcenizal
Remove dark theme when leaving the Dashboard app. Add dark theme for …
574da97 
…localNav. (#9052)

Backports PR #9032

**Commit 1:**
Remove dark theme when leaving the Dashboard app.

* Original sha: 700f750
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-10T19:40:34Z

**Commit 2:**
Upgrade kibana-ui-framework to 0.0.10: localNav dark theme styles.

* Original sha: c339694
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-10T19:48:10Z
@spalger
Copy link
Contributor

spalger commented Nov 12, 2016

Looks like the the selenium builds started failing after this was merged... for some reason https://kibana-ci.elastic.co/job/elastic+kibana+master+multijob-selenium/373/

@cjcenizal
Copy link
Contributor Author

@spalger I was able to sporadically reproduce locally. It failed once with similar errors, and then passed once. Not sure what's going on here.

@spalger
Copy link
Contributor

spalger commented Nov 12, 2016

Can you try to reproduce without your change? Perhaps it's just a coincidence...

@cjcenizal
Copy link
Contributor Author

I tried this out on two commits (my change and prior to my change) and was able to confirm that the bug is sporadically reproducible on both.

All of the tests involve Discover. But the actual tests which fail are different in each case (with some overlap). This makes me think there could be a race condition involved.

Possible next steps:

  • A scan of some of the most recent commits to see if anyone's made any changes to Discover which could affect this
  • A very slow, methodical git bisect
  • Dig into the test suite and look for race conditions

My change

Commit deec2eb

Errors

1478928655479_discover app_discover app

21:30:45.430: in findTestSubject: [data-test-subj~="globalTimepickerButton"]
21:30:55.479: Taking screenshot "/Users/cjcenizal/Documents/GitHub/Elastic/kibana/test/screenshots/failure/failure_1478928655479_discover app_discover app.png"
[28.415][WARNING]: screenshot failed, retrying
SUITE ERROR
NoSuchElement: An element could not be located on the page using the given search parameters.

failure_1478928655479_discover app_discover app

1478928675690_discover app_discover app

21:31:05.671: in findTestSubject: [data-test-subj~="globalTimepickerButton"]
21:31:15.690: Taking screenshot "/Users/cjcenizal/Documents/GitHub/Elastic/kibana/test/screenshots/failure/failure_1478928675690_discover app_discover app.png"
[48.664][WARNING]: screenshot failed, retrying
SUITE ERROR
NoSuchElement: An element could not be located on the page using the given search parameters.

failure_1478928675690_discover app_discover app

1478928718396_discover app_discover tab

21:31:48.332: in findTestSubject: [data-test-subj~="globalTimepickerButton"]
21:31:58.398: Taking screenshot "/Users/cjcenizal/Documents/GitHub/Elastic/kibana/test/screenshots/failure/failure_1478928718396_discover app_discover tab.png"
[91.327][WARNING]: screenshot failed, retrying
SUITE ERROR
NoSuchElement: An element could not be located on the page using the given search parameters.

failure_1478928718396_discover app_discover tab

1478928738503_discover app_source filters

21:32:08.468: in findTestSubject: [data-test-subj~="globalTimepickerButton"]
21:32:18.503: Taking screenshot "/Users/cjcenizal/Documents/GitHub/Elastic/kibana/test/screenshots/failure/failure_1478928738503_discover app_source filters.png"
[111.431][WARNING]: screenshot failed, retrying
SUITE ERROR
NoSuchElement: An element could not be located on the page using the given search parameters.

failure_1478928738503_discover app_source filters

Prior to my change

Commit 86cff96

Errors

1478971332938_query_save

09:22:11.362: in findTestSubject: [data-test-subj~="discover-save-search-btn"]
09:22:12.938: Taking screenshot "/Users/cjcenizal/Documents/GitHub/Elastic/kibana/test/screenshots/failure/failure_1478971332938_query_save query should show toast message and display query name.png"
>> FAIL: chrome on any platform - kibana - discover app - discover app - query - save query should show toast message and display query name (1988ms)
Error: expected 'Discover: Saved Data Source "New Saved Search"' to equal 'Discover: Saved Data Source "Query # 1"'
  at Assertion.assert  <node_modules/expect.js/index.js:96:13>

failure_1478971332938_query_save query should show toast message and display query name

1478971355018_discover app_discover app

  09:22:24.956: in findTestSubject: [data-test-subj~="globalTimepickerButton"]
09:22:35.018: Taking screenshot "/Users/cjcenizal/Documents/GitHub/Elastic/kibana/test/screenshots/failure/failure_1478971355018_discover app_discover app.png"
[46.047][WARNING]: screenshot failed, retrying
SUITE ERROR
NoSuchElement: An element could not be located on the page using the given search parameters.

failure_1478971355018_discover app_discover app

1478971389854_discover app_discover tab

09:22:59.838: in findTestSubject: [data-test-subj~="globalTimepickerButton"]
09:23:09.854: Taking screenshot "/Users/cjcenizal/Documents/GitHub/Elastic/kibana/test/screenshots/failure/failure_1478971389854_discover app_discover tab.png"
[80.857][WARNING]: screenshot failed, retrying
SUITE ERROR
NoSuchElement: An element could not be located on the page using the given search parameters.

failure_1478971389854_discover app_discover tab

@cjcenizal
Copy link
Contributor Author

Fixed by #9068

@spalger
Copy link
Contributor

spalger commented Nov 15, 2016

Nice investigative work @cjcenizal

@cjcenizal cjcenizal mentioned this pull request Nov 21, 2016
Closed
@epixa
Copy link
Contributor

epixa commented Dec 7, 2016

@cjcenizal What branches/versions did this go into?

@epixa
Copy link
Contributor

epixa commented Dec 7, 2016

Nevermind, I think I got it from the linked backport PRs

@epixa epixa added v5.1.0 and removed v5.1.0 labels Dec 7, 2016
@cjcenizal
Copy link
Contributor Author

@epixa Sorry... did you figure it out or would you like me to look into it?

@epixa
Copy link
Contributor

epixa commented Dec 7, 2016

@cjcenizal all good, thanks

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@elastic-jasper @cjcenizal
Remove dark theme when leaving the Dashboard app. Add dark theme for …
fa4e2e4 
…localNav. (elastic#9052)

Backports PR elastic#9032

**Commit 1:**
Remove dark theme when leaving the Dashboard app.

* Original sha: 700f750
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-10T19:40:34Z

**Commit 2:**
Upgrade kibana-ui-framework to 0.0.10: localNav dark theme styles.

* Original sha: c339694
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-10T19:48:10Z

Former-commit-id: 574da97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alt74 alt74

@ppisljar ppisljar

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjcenizal @ppisljar @alt74 @spalger @epixa