-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display search bar in embedded iframes #8947
Conversation
Can one of the admins verify this patch? |
@nreese could you add some screenshots and explanation of how the new functionality works to the PR description? |
Thanks @nreese, I updated the PR description with that info as well. |
please please please release this one! :) |
Hey @nreese! Thanks for spending time on this. The idea is great, and we want to take it even further - you can read more about those ideas in issue #9575. We haven't yet decided how the UI should look and where these extra options should go, but I'm pretty sure (because we expect there to be a few of them) we don't want to add all of them to that single share link panel. It would just get too cluttered. If you have any ideas on how you think the UI should look, if more embedding options were available, I'd love to hear them! Otherwise stay tuned and subscribe to that issue for further updates. Once some of those decisions are made we can re-visit this PR. |
Provide ability to display search bar when viewing dashboards and visualizations in embedded iframes.
A checkbox labeled "Show Search Bar" has been added to the share GUI. When checked, the embedded URL includes the parameter showSearch=true.
When the embedded iframe is rendered and showSearch is set to true, the kbn-top-nav is visible and displays the search bar.
fixes #3046