-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Cleaning up Discover to match UI. #8849
Conversation
@debadair These docs aren't building cleanly for me locally, though master itself is working fine. |
Hmm. I just pulled the latest from master & rebuilt...and they build without errors. What error are you getting? |
92e37b2
to
60719b4
Compare
I still get the build error using the latest master of elastic/docs and this PR on Kibana. Here's the output:
|
I still have a hard time parsing the output of the docs build tool, but I think this is the issue: |
Is it possible that you have the image checked out locally but it didn't get added to the commit? |
That would indeed cause the problem you're seeing. :-) Fixing. |
60719b4
to
b680f3d
Compare
@debadair The contrast on the annotated screenshot on the first page got messed up pretty badly somehow: Compare that to screenshots from visualize, which do not have the same issue: |
Flux happens. Sigh. That's not really part of this push. I think we should push these changes & I'll update the errant screen cap. |
Former-commit-id: e4de00d
No description provided.