[ML] Improving existing job check in anomaly detection wizard

[jgowdyelastic]

The new job wizards for anomaly detection jobs now use the /api/ml/jobs/jobs_exist endpoint as the user is typing, rather than using a preloaded list of existing jobs.

When entering a job ID, a user cannot use a job or group ID that has already been used in any space.
When entering a group ID, the user cannot use an ID that has been used as a job ID in any space. Reusing a group ID is fine as it'll just add the new job to the existing group.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[jgowdyelastic]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[jgowdyelastic]

@elasticmachine merge upstream

[peteharverson]

When logged into a non-Default space, I am seeing this error in the server console when typing in an ID which exists only in the Default space (Single metric job wizard):

And in the network tab I see:

{"statusCode":500,"error":"Internal Server Error","message":"Cannot read property 'includes' of undefined"}

[darnautov]

Suggested change

	const message =
	jobValidator.groupIds.message === undefined
	? jobValidator.latestValidationResult.groupIdsExist?.message
	: jobValidator.groupIds.message;
	const message = jobValidator.groupIds.message ?? jobValidator.latestValidationResult.groupIdsExist?.message;

[jgowdyelastic]

@elasticmachine merge upstream

[peteharverson]

Can this check be extended to the groups control of the edit job flyout? Currently you don't get an in-form error if you try to add a group which already exists as a job ID in another space:

[jgowdyelastic]

@peteharverson

Can this check be extended to the groups control of the edit job flyout? Currently you don't get an in-form error if you try to add a group which already exists as a job ID in another space

added group id check to the edit job flyout in 6029c11

It is also possible to add a group using the multi-select controls in the jobs list.
Adding async validation to this component is quite a bit of work, so much so that it'd probably be worth completely rewriting the component in typescript and so is outside of the scope of this PR.

I think the current behaviour is acceptable. Jobs in the current space are checked for duplication but if you attempt to add a group which already exists as a job id in a different space, when you try to apply the changes a toast is displayed.

[darnautov]

Code LGTM, just one small suggestion

[peteharverson]

Tested latest changes and LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 30afea5

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
ml	7.1MB	7.1MB	+2.7KB

History

• 💚 Build #98924 succeeded 6afda2d
• 💚 Build #98821 succeeded a56549a
• 💔 Build #98801 failed 21b999a
• 💚 Build #98624 succeeded 325605c
• 💔 Build #98560 failed 880dba5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream