Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Prettify JSON in "Show request" flyout #87612

Merged
merged 2 commits into from
Jan 11, 2021
Merged

[ILM] Prettify JSON in "Show request" flyout #87612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
510e8cc
prettify json
jloleysens Jan 7, 2021
a07dec8
Merge branch 'master' into ilm/prettify-request-json
kibanamachine Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ...ycle_management/public/application/sections/edit_policy/components/policy_json_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,19 @@ interface Props {
policyName: string;
}

/**
* Ensure that the JSON we get from the from has phases in the correct order.
*/
const prettifyFormJson = (policy: SerializedPolicy): SerializedPolicy => ({
...policy,
phases: {
hot: policy.phases.hot,
warm: policy.phases.warm,
cold: policy.phases.cold,
delete: policy.phases.delete,
},
});

export const PolicyJsonFlyout: React.FunctionComponent<Props> = ({ policyName, close }) => {
/**
* policy === undefined: we are checking validity
Expand All @@ -46,7 +59,7 @@ export const PolicyJsonFlyout: React.FunctionComponent<Props> = ({ policyName, c
const updatePolicy = useCallback(async () => {
setPolicy(undefined);
if (await validateForm()) {
setPolicy(getFormData() as SerializedPolicy);
setPolicy(prettifyFormJson(getFormData()));
} else {
setPolicy(null);
}
Expand Down