Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Adds purely visual changes to to the popovers and the settings view. #86764

Merged
merged 7 commits into from
Jan 4, 2021
Merged

[Logs UI] Adds purely visual changes to to the popovers and the settings view. #86764

merged 7 commits into from
Jan 4, 2021

Conversation

katrin-freihofner
Copy link
Contributor

Summary

Changes according to latest design audit: https://github.com/elastic/observability-design/issues/15

Screenshot 2020-12-22 at 14 03 52

Screenshot 2020-12-22 at 14 04 00

Screenshot 2020-12-22 at 14 09 28

@katrin-freihofner katrin-freihofner requested a review from a team as a code owner December 22, 2020 13:13
@katrin-freihofner katrin-freihofner changed the title Adds purely visual changes to to the popovers and the settings view. [Logs UI] Adds purely visual changes to to the popovers and the settings view. Dec 22, 2020
@katrin-freihofner katrin-freihofner added v7.12.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 22, 2020
@katrin-freihofner katrin-freihofner added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Dec 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez self-requested a review December 28, 2020 11:36
afgomez
afgomez approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

x-pack/plugins/infra/public/components/logging/log_text_stream/log_entry_context_menu.tsx
@@ -79,7 +79,12 @@ export const LogEntryContextMenu: React.FC<LogEntryContextMenuProps> = ({
return (
<LogEntryContextMenuContent>
<AbsoluteWrapper>
<EuiPopover closePopover={onClose} isOpen={isOpen} button={button} ownFocus={true}>
<EuiPopover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can correct the indentation here with prettier

$ yarn prettier -w x-pack/plugins/infra/public/components/logging/log_text_stream/log_entry_context_menu.tsx

@katrin-freihofner
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.7MB 2.7MB +58.0B

Distributable file count

id before after diff
default 47264 48024 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 183.1KB 183.1KB +24.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@katrin-freihofner katrin-freihofner merged commit 9c092d5 into elastic:master Jan 4, 2021
@katrin-freihofner katrin-freihofner deleted the logs-ui-polish branch January 4, 2021 16:56
@katrin-freihofner katrin-freihofner mentioned this pull request Jan 5, 2021
Merged
katrin-freihofner added a commit that referenced this pull request Jan 5, 2021
@katrin-freihofner @kibanamachine
[7.x] [Logs UI] Adds purely visual changes to to the popovers and the…
f93c0d7 
… settings view. (#86764) (#87282)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afgomez afgomez afgomez approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katrin-freihofner @elasticmachine @kibanamachine @afgomez