Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Refactor param editor to use layers #86499

Merged
merged 2 commits into from
Dec 21, 2020
Merged

[Lens] Refactor param editor to use layers #86499

merged 2 commits into from
Dec 21, 2020

Conversation

wylieconlon
Copy link
Contributor

This change has no user-facing implications, but is related to the refactorings needed for the work on reference-based operations: #84384

Checklist

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.12.0 labels Dec 18, 2020
@wylieconlon wylieconlon requested a review from a team December 18, 2020 18:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Chrome and still works

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.0MB 1.0MB -185.0B

Distributable file count

id before after diff
default 47142 47902 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon merged commit 664a755 into elastic:master Dec 21, 2020
@wylieconlon wylieconlon deleted the lens/refactor-parameditor branch December 21, 2020 16:19
@wylieconlon wylieconlon mentioned this pull request Dec 21, 2020
Merged
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Dec 21, 2020
@kibanamachine @wylieconlon
[Lens] Refactor param editor to use layers (elastic#86499)
daf48c8 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
wylieconlon pushed a commit that referenced this pull request Dec 21, 2020
@kibanamachine
[Lens] Refactor param editor to use layers (#86499) (#86656)
0f77d66 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@dej611 dej611 Awaiting requested review from dej611

@mbondyra mbondyra Awaiting requested review from mbondyra

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wylieconlon @elasticmachine @flash1293 @kibanamachine