Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Toggle log entry context menu when user clicks the trigger button #86307

Merged
merged 2 commits into from
Dec 21, 2020
Merged

[Logs UI] Toggle log entry context menu when user clicks the trigger button #86307

merged 2 commits into from
Dec 21, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Dec 17, 2020

Summary

Fixes #85823

When the user clicked the trigger button for the context menu twice, the menu stayed on the screen.

Kapture 2020-12-10 at 17 58 47

This PR fixes that toggling the menu instead.

@afgomez afgomez added bug Fixes for quality problems that affect the customer experience v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Dec 17, 2020
@afgomez afgomez requested a review from a team as a code owner December 17, 2020 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

katrin-freihofner
katrin-freihofner approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for adding this!

weltenwort
weltenwort approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending a proper release-note label 👍

@afgomez afgomez added the release_note:skip Skip the PR/issue when compiling release notes label Dec 21, 2020
@afgomez
Copy link
Contributor Author

afgomez commented Dec 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.7MB 2.7MB +15.0B

Distributable file count

id before after diff
default 47142 47902 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 34803ed into elastic:master Dec 21, 2020
@afgomez afgomez deleted the 85823-log-stream-context-menu-toggle branch December 21, 2020 14:13
@afgomez afgomez mentioned this pull request Dec 21, 2020
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Dec 21, 2020
@kibanamachine
[Logs UI] Toggle log entry context menu when user clicks the trigger …
1685a15 
…button (elastic#86307)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@afgomez afgomez mentioned this pull request Dec 21, 2020
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 23, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

afgomez pushed a commit that referenced this pull request Dec 28, 2020
@kibanamachine
[7.11] [Logs UI] Toggle log entry context menu when user clicks the t…
e6e8b10 
…rigger button (#86307) (#86646)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 29, 2020
afgomez pushed a commit that referenced this pull request Dec 29, 2020
@kibanamachine
[7.x] [Logs UI] Toggle log entry context menu when user clicks the tr…
6db39e0 
…igger button (#86307) (#86645)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

@katrin-freihofner katrin-freihofner katrin-freihofner approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] Clicking the context menu button a 2nd time causes the menu to persist
5 participants
@afgomez @elasticmachine @kibanamachine @weltenwort @katrin-freihofner