Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Case] Attach alerts to cases: Tests #86305

Merged
merged 30 commits into from
Jan 11, 2021
Merged

[Security Solution][Case] Attach alerts to cases: Tests #86305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
fb48adc
Add/Imporve tests for case creation
cnasikas Dec 17, 2020
dfb2167
Sync alert switch test
cnasikas Dec 18, 2020
9885bda
Add test for StatusContextMenu
cnasikas Dec 18, 2020
4ecd8d6
Add test for case action bar helpers
cnasikas Dec 18, 2020
afe9f8b
Add test for CaseActionBar
cnasikas Dec 18, 2020
8e06edd
Improve all cases test
cnasikas Dec 21, 2020
5d16c00
Add test for StatusFilter
cnasikas Dec 21, 2020
738b298
Add test for StatusActionButton
cnasikas Dec 21, 2020
c393849
Add test for Stats
cnasikas Dec 21, 2020
ec92e1d
Add test for Status
cnasikas Dec 21, 2020
97bb895
Add test for UserActionShowAlert
cnasikas Dec 21, 2020
42e29d1
Improve helpers
cnasikas Dec 21, 2020
e9047b7
Add case view helpers
cnasikas Dec 21, 2020
d9e7c33
Improve case view test
cnasikas Dec 21, 2020
5a9f9ac
Add tests for AlertCommentEvent
cnasikas Dec 21, 2020
264072b
Add test for updateAlertsStatus
cnasikas Dec 23, 2020
fff76a5
Add test for AlertService
cnasikas Dec 23, 2020
d29450b
Improve add test
cnasikas Dec 23, 2020
4b0c338
Add test for settings in case view
cnasikas Dec 23, 2020
6f5bb98
Improve update test
cnasikas Dec 23, 2020
f6e7b32
Add test for get status route
cnasikas Dec 23, 2020
6f013f8
Add tests for create case modal
cnasikas Jan 4, 2021
bb06053
Add test for AddToCaseAction
cnasikas Jan 4, 2021
c7bf3a4
Add test for AddToCaseAction in EventColumnView
cnasikas Jan 4, 2021
8006e3c
Add test for useInsertTimeline
cnasikas Jan 4, 2021
4773519
Add integration tests
cnasikas Jan 5, 2021
d725669
PR feedback
cnasikas Jan 7, 2021
18f1be5
few more cleanups
stephmilovic Jan 7, 2021
2a48b78
Fix types
cnasikas Jan 7, 2021
3936f23
Merge branch 'master' into case_alerts_tests
kibanamachine Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions x-pack/plugins/case/server/client/alerts/update_status.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import { CaseStatuses } from '../../../common/api';
import { createMockSavedObjectsRepository } from '../../routes/api/__fixtures__';
import { createCaseClientWithMockSavedObjectsClient } from '../mocks';

describe('updateAlertsStatus', () => {
describe('happy path', () => {
test('it update the status of the alert correctly', async () => {
const savedObjectsClient = createMockSavedObjectsRepository();

const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
await caseClient.client.updateAlertsStatus({
ids: ['alert-id-1'],
status: CaseStatuses.closed,
});

expect(caseClient.services.alertsService.updateAlertsStatus).toHaveBeenCalledWith({
ids: ['alert-id-1'],
index: '.siem-signals',
request: {},
status: CaseStatuses.closed,
});
});

describe('unhappy path', () => {
test('it throws when missing securitySolutionClient', async () => {
expect.assertions(3);

const savedObjectsClient = createMockSavedObjectsRepository();

const caseClient = await createCaseClientWithMockSavedObjectsClient({
savedObjectsClient,
omitFromContext: ['securitySolution'],
});
caseClient.client
.updateAlertsStatus({
ids: ['alert-id-1'],
status: CaseStatuses.closed,
})
.catch((e) => {
expect(e).not.toBeNull();
expect(e.isBoom).toBe(true);
expect(e.output.statusCode).toBe(404);
});
});
});
});
});
23 changes: 13 additions & 10 deletions x-pack/plugins/case/server/client/cases/create.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('create', () => {
caseSavedObject: mockCases,
caseConfigureSavedObject: mockCaseConfigure,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
const res = await caseClient.client.create({ theCase: postCase });

expect(res).toEqual({
Expand Down Expand Up @@ -120,7 +120,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
const res = await caseClient.client.create({ theCase: postCase });

expect(res).toEqual({
Expand Down Expand Up @@ -165,7 +165,10 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient, true);
const caseClient = await createCaseClientWithMockSavedObjectsClient({
savedObjectsClient,
badAuth: true,
});
const res = await caseClient.client.create({ theCase: postCase });

expect(res).toEqual({
Expand Down Expand Up @@ -213,7 +216,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
caseClient.client
// @ts-expect-error
.create({ theCase: postCase })
Expand All @@ -240,7 +243,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
caseClient.client
// @ts-expect-error
.create({ theCase: postCase })
Expand All @@ -267,7 +270,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
caseClient.client
// @ts-expect-error
.create({ theCase: postCase })
Expand All @@ -289,7 +292,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
caseClient.client
// @ts-expect-error
.create({ theCase: postCase })
Expand Down Expand Up @@ -317,7 +320,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
caseClient.client
// @ts-expect-error
.create({ theCase: postCase })
Expand Down Expand Up @@ -349,7 +352,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });
caseClient.client.create({ theCase: postCase }).catch((e) => {
expect(e).not.toBeNull();
expect(e.isBoom).toBe(true);
Expand All @@ -375,7 +378,7 @@ describe('create', () => {
const savedObjectsClient = createMockSavedObjectsRepository({
caseSavedObject: mockCases,
});
const caseClient = await createCaseClientWithMockSavedObjectsClient(savedObjectsClient);
const caseClient = await createCaseClientWithMockSavedObjectsClient({ savedObjectsClient });

caseClient.client.create({ theCase: postCase }).catch((e) => {
expect(e).not.toBeNull();
Expand Down
Loading