Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerts] Removed mocking hacks from alert plugin.test.ts #86206

Merged
merged 1 commit into from
Dec 17, 2020
Merged

[Alerts] Removed mocking hacks from alert plugin.test.ts #86206

merged 1 commit into from
Dec 17, 2020

Conversation

YulNaumenko
Copy link
Contributor

Resolve #57043

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 labels Dec 16, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner December 16, 2020 23:02
@YulNaumenko YulNaumenko self-assigned this Dec 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47287 48047 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote self-requested a review December 17, 2020 13:03
mikecote
mikecote approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better, LGTM!

ymao1
ymao1 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YulNaumenko YulNaumenko merged commit 76670ec into elastic:master Dec 17, 2020
@YulNaumenko YulNaumenko mentioned this pull request Dec 17, 2020
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Dec 17, 2020
@YulNaumenko
Removed mocking hacks from alert plugin.test.ts (elastic#86206)
f2efff3
YulNaumenko added a commit that referenced this pull request Dec 17, 2020
@YulNaumenko
Removed mocking hacks from alert plugin.test.ts (#86206) (#86318)
1b9a9b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hacks from alert plugin.test.ts once migrated to new platform
5 participants
@YulNaumenko @elasticmachine @kibanamachine @mikecote @ymao1