[actions] expand object context variables as JSON #85903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dd5f05 to
cfb20f1
Compare
resolves elastic#75601 Previously, if a context variable that is an object is referenced in a mustache template used as an action parameter, the resulting variable expansion will be `[Object object]`. In this PR, we change this so that the expansion is a JSON representation of the object. This is primarily for diagnostic purposes, so that customers can see all the context variables available, and their values, while testing testing their alerting actions.
cfb20f1 to
ada56f6
Compare
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
approved these changes
Dec 15, 2020
YulNaumenko
approved these changes
Dec 15, 2020
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Dec 15, 2020
resolves elastic#75601 Previously, if a context variable that is an object is referenced in a mustache template used as an action parameter, the resulting variable expansion will be `[Object object]`. In this PR, we change this so that the expansion is a JSON representation of the object. This is primarily for diagnostic purposes, so that customers can see all the context variables available, and their values, while testing testing their alerting actions.
pmuellr
added a commit
that referenced
this pull request
Dec 16, 2020
resolves #75601 Previously, if a context variable that is an object is referenced in a mustache template used as an action parameter, the resulting variable expansion will be `[Object object]`. In this PR, we change this so that the expansion is a JSON representation of the object. This is primarily for diagnostic purposes, so that customers can see all the context variables available, and their values, while testing testing their alerting actions.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #75601
Summary
Previously, if a context variable that is an object is referenced in a
mustache template used as an action parameter, the resulting variable
expansion will be
[Object object]. In this PR, we change this so thatthe expansion is a JSON representation of the object.
This is primarily for diagnostic purposes, so that customers can see
all the context variables available, and their values, while testing
testing their alerting actions.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)This was checked for cross-browser compatibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately