[Lens] Fix esaggs missing default time field scenario in Lens #85754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
mattkime
approved these changes
Dec 15, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
flash1293
approved these changes
Dec 16, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
This was referenced Dec 21, 2020
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Dec 21, 2020
…c#85754) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84058
This PR addresses only partially the problem of missing default time field, focusing only on Lens.
The fix prevents the esaggs to break when querying with a missing default time field.
The fix should not break any other plugin like Visualize or Discover, which are still reporting the missing field error.
Lens
When not using directly default time field, the editor is behaving as the indexpattern has no default time field.
When using directly the default time field, the editor is now correctly showing the invalid reference message.
Visualize
When using directly the field, because of changes in #82223, the user is redirected to the Saved Object specific page when trying to open the visualization. (Note in console it still shows the
Error: Could not locate that index-pattern-field (id: "default-time-field-name-here")message.Discover
When opening the indexpattern the user is still facing an error when the toast message with
Error: Could not locate that index-pattern-field (id: "default-time-field-name-here")Checklist