[Monitoring] Convert Beats-related server files that read from _source to typescript #85193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
5 tasks
igoristic
reviewed
Dec 8, 2020
| @@ -25,47 +46,47 @@ export function handleResponse(response, start, end) { | |||
|
|
|||
| // add another beat summary | |||
| accum.ids.add(uuid); | |||
| const earliestStats = get(hit, 'inner_hits.earliest.hits.hits[0]._source.beats_stats'); | |||
| const earliestStats = hit.inner_hits.earliest.hits.hits[0]._source.beats_stats; | |||
There was a problem hiding this comment.
I think this might need some safeguarding as well, something like:
Suggested change
| const earliestStats = hit.inner_hits.earliest.hits.hits[0]._source.beats_stats; | |
| const earliestStats = hit.inner_hits?.earliest?.hits?.hits[0]?._source?.beats_stats; |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Dec 14, 2020
…e to typescript (elastic#85193) * Beats to TS * PR feedback * Fix types * Fix types * Fix failing test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #84370
This PR updates a couple source files used for Beats monitoring that read from source to using Typescript. This is an attempt to identify all fields read from source to help with #73864
I'm going to try and do one PR for each stack product to avoid long reviews.