Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:jest improvements to better support our monorepo #84848

Merged
merged 4 commits into from
Dec 14, 2020
Merged

test:jest improvements to better support our monorepo #84848

merged 4 commits into from
Dec 14, 2020

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Dec 2, 2020 •
edited
Loading

Improves the yarn test:jest script to provide a better testing experience while navigating throughout the monorepo. To run the tests within your current working directory, use yarn test:jest. Like the Jest CLI, you can also supply a path to determine which tests to run. The best-suited Jest configuration will be selected based on your current working directory, or the path provided to ensure the tests start as quickly as possible. Any additional arguments are passed onto the Jest CLI, like --coverage.

image

Details are available in the updated docs: https://kibana_84848.docs-preview.app.elstc.co/guide/en/kibana/master/development-tests.html#_unit_testing

This removes any differences there was between how unit tests are run in OSS or X-Pack.

@tylersmalley tylersmalley mentioned this pull request Dec 2, 2020
Merged
1 task
@tylersmalley tylersmalley mentioned this pull request Dec 8, 2020
Merged
@tylersmalley tylersmalley force-pushed the jest-global branch 4 times, most recently from 0de2f02 to 81e2176 Compare December 10, 2020 00:50
@tylersmalley tylersmalley changed the title WIP: Jest global runner Jest global runner Dec 10, 2020
@tylersmalley tylersmalley force-pushed the jest-global branch 3 times, most recently from c350d21 to d591472 Compare December 10, 2020 07:42
@tylersmalley tylersmalley changed the title Jest global runner Jest mono-repo support Dec 10, 2020
@tylersmalley tylersmalley changed the title Jest mono-repo support Jest mono-repo helper Dec 10, 2020
@tylersmalley tylersmalley changed the title Jest mono-repo helper Jest monorepo helper Dec 10, 2020
@tylersmalley tylersmalley force-pushed the jest-global branch 5 times, most recently from cbb1bd9 to e195cc2 Compare December 10, 2020 22:05
@tylersmalley tylersmalley changed the title Jest monorepo helper test:jest improvements to better support our monorepo Dec 11, 2020
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0 labels Dec 11, 2020
Updates test:jest script
8364444 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley marked this pull request as ready for review December 11, 2020 02:32
@tylersmalley tylersmalley requested a review from a team December 11, 2020 02:32
@tylersmalley tylersmalley requested a review from a team as a code owner December 11, 2020 02:32
@tylersmalley tylersmalley requested a review from a team December 11, 2020 02:32
@tylersmalley tylersmalley requested review from a team as code owners December 11, 2020 02:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

legrego
legrego approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to x-pack/plugins/encrypted_saved_objects/README.md LGTM 🎉

flash1293
flash1293 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme changes LGTM

peteharverson
peteharverson approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to ML and Transforms READMEs LGTM

shahzad31
shahzad31 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks so much clean

mikecote
mikecote approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

cee-chen
cee-chen approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo! Enterprise Search team is super excited for this :)

Tyler Smalley added 2 commits December 14, 2020 11:54
@tylersmalley tylersmalley mentioned this pull request Dec 14, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB -58.0B

Distributable file count

id before after diff
default 47138 47898 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.1KB 60.0KB -58.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 504c873 into elastic:master Dec 14, 2020
@tylersmalley tylersmalley mentioned this pull request Dec 14, 2020
Merged
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Dec 14, 2020
test:jest improvements to better support our monorepo (elastic#84848)
2bbb283 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	docs/developer/contributing/development-functional-tests.asciidoc
#	test/scripts/jenkins_unit.sh
#	test/scripts/jenkins_xpack.sh
#	x-pack/README.md
tylersmalley pushed a commit that referenced this pull request Dec 15, 2020
@kibanamachine
test:jest improvements to better support our monorepo (#84848) (#85880)
82225db 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	docs/developer/contributing/development-functional-tests.asciidoc
#	test/scripts/jenkins_unit.sh
#	test/scripts/jenkins_xpack.sh
#	x-pack/README.md

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

@flash1293 flash1293 flash1293 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@jbudz jbudz jbudz approved these changes

@legrego legrego legrego approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@mikecote mikecote mikecote approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.