Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY SOLUTIONS] Bring Async Search Back #82650

Merged
merged 6 commits into from
Nov 5, 2020
Merged

[SECURITY SOLUTIONS] Bring Async Search Back #82650

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8b8b99
bring async search back to the security solutions
XavierM Nov 4, 2020
f08eb51
remove id for timeline details searchStrategy
angorayc Nov 4, 2020
3358fa7
fix events count
patrykkopycinski Nov 5, 2020
e57848e
fix total count
patrykkopycinski Nov 5, 2020
8abcd78
update units
patrykkopycinski Nov 5, 2020
77508d9
update integration tests
patrykkopycinski Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions x-pack/plugins/security_solution/public/common/containers/events/last_event_time/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ import {
import * as i18n from './translations';
import { DocValueFields } from '../../../../../common/search_strategy';

const ID = 'timelineEventsLastEventTimeQuery';

export interface UseTimelineLastEventTimeArgs {
lastSeen: string | null;
refetch: inputsModel.Refetch;
Expand Down Expand Up @@ -56,7 +54,6 @@ export const useTimelineLastEventTime = ({
defaultIndex: indexNames,
docValueFields,
factoryQueryType: TimelineEventsQueries.lastEventTime,
id: ID,
indexKey,
details,
});
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/security_solution/public/common/containers/matrix_histogram/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ export interface UseMatrixHistogramArgs {
}>;
}

const ID = 'matrixHistogramQuery';

export const useMatrixHistogram = ({
endDate,
errorMessage,
Expand All @@ -73,7 +71,6 @@ export const useMatrixHistogram = ({
factoryQueryType: MatrixHistogramQuery,
filterQuery: createFilter(filterQuery),
histogramType,
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/hosts/containers/authentications/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export const useAuthentications = ({
docValueFields: docValueFields ?? [],
factoryQueryType: HostsQueries.authentications,
filterQuery: createFilter(filterQuery),
id: ID,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
interval: '12h',
Expand Down Expand Up @@ -203,7 +202,6 @@ export const useAuthentications = ({
docValueFields: docValueFields ?? [],
factoryQueryType: HostsQueries.authentications,
filterQuery: createFilter(filterQuery),
id: ID,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
interval: '12h',
Expand Down
4 changes: 1 addition & 3 deletions x-pack/plugins/security_solution/public/hosts/containers/hosts/details/_index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export const useHostDetails = ({
? {
defaultIndex: indexNames,
hostName,
id,
factoryQueryType: HostsQueries.details,
timerange: {
interval: '12h',
Expand All @@ -79,7 +78,7 @@ export const useHostDetails = ({
const [hostDetailsResponse, setHostDetailsResponse] = useState<HostDetailsArgs>({
endDate,
hostDetails: {},
id: ID,
id,
inspect: {
dsl: [],
response: [],
Expand Down Expand Up @@ -154,7 +153,6 @@ export const useHostDetails = ({
defaultIndex: indexNames,
factoryQueryType: HostsQueries.details,
hostName,
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/hosts/containers/hosts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export const useAllHost = ({
docValueFields: docValueFields ?? [],
factoryQueryType: HostsQueries.hosts,
filterQuery: createFilter(filterQuery),
id: ID,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
interval: '12h',
Expand Down Expand Up @@ -200,7 +199,6 @@ export const useAllHost = ({
docValueFields: docValueFields ?? [],
factoryQueryType: HostsQueries.hosts,
filterQuery: createFilter(filterQuery),
id: ID,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
interval: '12h',
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/hosts/containers/kpi_hosts/authentications/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export const useHostsKpiAuthentications = ({
defaultIndex: indexNames,
factoryQueryType: HostsKpiQueries.kpiAuthentications,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -159,7 +158,6 @@ export const useHostsKpiAuthentications = ({
defaultIndex: indexNames,
factoryQueryType: HostsKpiQueries.kpiAuthentications,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/hosts/containers/kpi_hosts/hosts/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ export const useHostsKpiHosts = ({
defaultIndex: indexNames,
factoryQueryType: HostsKpiQueries.kpiHosts,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -149,7 +148,6 @@ export const useHostsKpiHosts = ({
defaultIndex: indexNames,
factoryQueryType: HostsKpiQueries.kpiHosts,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/hosts/containers/kpi_hosts/unique_ips/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export const useHostsKpiUniqueIps = ({
defaultIndex: indexNames,
factoryQueryType: HostsKpiQueries.kpiUniqueIps,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -156,7 +155,6 @@ export const useHostsKpiUniqueIps = ({
defaultIndex: indexNames,
factoryQueryType: HostsKpiQueries.kpiUniqueIps,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/hosts/containers/uncommon_processes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export const useUncommonProcesses = ({
docValueFields: docValueFields ?? [],
factoryQueryType: HostsQueries.uncommonProcesses,
filterQuery: createFilter(filterQuery),
id: ID,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
interval: '12h',
Expand Down Expand Up @@ -204,7 +203,6 @@ export const useUncommonProcesses = ({
docValueFields: docValueFields ?? [],
factoryQueryType: HostsQueries.uncommonProcesses,
filterQuery: createFilter(filterQuery),
id: ID,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
interval: '12h',
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/network/containers/details/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ export const useNetworkDetails = ({
docValueFields: docValueFields ?? [],
factoryQueryType: NetworkQueries.details,
filterQuery: createFilter(filterQuery),
id,
ip,
}
: null
Expand Down Expand Up @@ -153,7 +152,6 @@ export const useNetworkDetails = ({
docValueFields: docValueFields ?? [],
factoryQueryType: NetworkQueries.details,
filterQuery: createFilter(filterQuery),
id,
ip,
};
if (!skip && !deepEqual(prevRequest, myRequest)) {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/network/containers/kpi_network/dns/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export const useNetworkKpiDns = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.dns,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -152,7 +151,6 @@ export const useNetworkKpiDns = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.dns,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions .../plugins/security_solution/public/network/containers/kpi_network/network_events/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export const useNetworkKpiNetworkEvents = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.networkEvents,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -157,7 +156,6 @@ export const useNetworkKpiNetworkEvents = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.networkEvents,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions .../plugins/security_solution/public/network/containers/kpi_network/tls_handshakes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export const useNetworkKpiTlsHandshakes = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.tlsHandshakes,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -156,7 +155,6 @@ export const useNetworkKpiTlsHandshakes = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.tlsHandshakes,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions ...ck/plugins/security_solution/public/network/containers/kpi_network/unique_flows/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ export const useNetworkKpiUniqueFlows = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.uniqueFlows,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -157,7 +156,6 @@ export const useNetworkKpiUniqueFlows = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.uniqueFlows,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions ...gins/security_solution/public/network/containers/kpi_network/unique_private_ips/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ export const useNetworkKpiUniquePrivateIps = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.uniquePrivateIps,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -168,7 +167,6 @@ export const useNetworkKpiUniquePrivateIps = ({
defaultIndex: indexNames,
factoryQueryType: NetworkKpiQueries.uniquePrivateIps,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/network/containers/network_dns/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ export const useNetworkDns = ({
defaultIndex: indexNames,
factoryQueryType: NetworkQueries.dns,
filterQuery: createFilter(filterQuery),
id: ID,
isPtrIncluded,
pagination: generateTablePaginationOptions(activePage, limit),
sort,
Expand Down Expand Up @@ -197,7 +196,6 @@ export const useNetworkDns = ({
isPtrIncluded,
factoryQueryType: NetworkQueries.dns,
filterQuery: createFilter(filterQuery),
id: ID,
pagination: generateTablePaginationOptions(activePage, limit),
sort,
timerange: {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/network/containers/network_http/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const useNetworkHttp = ({
defaultIndex: indexNames,
factoryQueryType: NetworkQueries.http,
filterQuery: createFilter(filterQuery),
id: ID,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort: sort as SortField,
Expand Down Expand Up @@ -197,7 +196,6 @@ export const useNetworkHttp = ({
defaultIndex: indexNames,
factoryQueryType: NetworkQueries.http,
filterQuery: createFilter(filterQuery),
id: ID,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort: sort as SortField,
Expand Down
16 changes: 1 addition & 15 deletions x-pack/plugins/security_solution/public/network/containers/network_top_countries/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ export const useNetworkTopCountries = ({
factoryQueryType: NetworkQueries.topCountries,
filterQuery: createFilter(filterQuery),
flowTarget,
id: queryId,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort,
Expand Down Expand Up @@ -204,7 +203,6 @@ export const useNetworkTopCountries = ({
factoryQueryType: NetworkQueries.topCountries,
filterQuery: createFilter(filterQuery),
flowTarget,
id: queryId,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort,
Expand All @@ -219,19 +217,7 @@ export const useNetworkTopCountries = ({
}
return prevRequest;
});
}, [
activePage,
indexNames,
endDate,
filterQuery,
ip,
limit,
startDate,
sort,
skip,
flowTarget,
queryId,
]);
}, [activePage, indexNames, endDate, filterQuery, ip, limit, startDate, sort, skip, flowTarget]);

useEffect(() => {
networkTopCountriesSearch(networkTopCountriesRequest);
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/network/containers/network_top_n_flow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export const useNetworkTopNFlow = ({
factoryQueryType: NetworkQueries.topNFlow,
filterQuery: createFilter(filterQuery),
flowTarget,
id: `${ID}-${flowTarget}`,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort,
Expand Down Expand Up @@ -201,7 +200,6 @@ export const useNetworkTopNFlow = ({
factoryQueryType: NetworkQueries.topNFlow,
filterQuery: createFilter(filterQuery),
flowTarget,
id: `${ID}-${flowTarget}`,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/network/containers/tls/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const useNetworkTls = ({
factoryQueryType: NetworkQueries.tls,
filterQuery: createFilter(filterQuery),
flowTarget,
id,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort,
Expand Down Expand Up @@ -195,7 +194,6 @@ export const useNetworkTls = ({
factoryQueryType: NetworkQueries.tls,
filterQuery: createFilter(filterQuery),
flowTarget,
id,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
timerange: {
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/security_solution/public/network/containers/users/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export const useNetworkUsers = ({
factoryQueryType: NetworkQueries.users,
filterQuery: createFilter(filterQuery),
flowTarget,
id,
ip,
pagination: generateTablePaginationOptions(activePage, limit),
sort,
Expand Down Expand Up @@ -192,7 +191,6 @@ export const useNetworkUsers = ({
setNetworkUsersRequest((prevRequest) => {
const myRequest = {
...(prevRequest ?? {}),
id,
ip,
defaultIndex,
factoryQueryType: NetworkQueries.users,
Expand Down Expand Up @@ -222,7 +220,6 @@ export const useNetworkUsers = ({
skip,
ip,
flowTarget,
id,
]);

useEffect(() => {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/security_solution/public/overview/containers/overview_host/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export const useHostOverview = ({
defaultIndex: indexNames,
factoryQueryType: HostsQueries.overview,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down Expand Up @@ -148,7 +147,6 @@ export const useHostOverview = ({
defaultIndex: indexNames,
factoryQueryType: HostsQueries.overview,
filterQuery: createFilter(filterQuery),
id: ID,
timerange: {
interval: '12h',
from: startDate,
Expand Down
Loading