Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Remove visible title in workspace panel #82234

Merged
merged 5 commits into from
Nov 5, 2020
Merged

[Lens] Remove visible title in workspace panel #82234

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92aeaed
[Lens] Remove visible title in workspace panel
lykims Nov 2, 2020
65f2744
[Lens] Remove visible title in workspace panel
lykims Nov 4, 2020
d01c15b
Merge branch 'master' into bug/lens-workspace-title
kibanamachine Nov 4, 2020
4e1d836
[Lens] Remove visible title in workspace panel - Fix type check
lykims Nov 4, 2020
ac9dccc
Merge branch 'master' into bug/lens-workspace-title
kibanamachine Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ export function WorkspacePanel({
title={title}
framePublicAPI={framePublicAPI}
dispatch={dispatch}
emptyExpression={expression === null}
visualizationState={visualizationState}
visualizationId={activeVisualizationId}
datasourceStates={datasourceStates}
Expand Down
11 changes: 0 additions & 11 deletions ...ens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,6 @@
position: relative; // For positioning the dnd overlay
min-height: $euiSizeXXL * 10;

.lnsWorkspacePanelWrapper__pageContentHeader {
@include euiTitle('xs');
padding: $euiSizeM;
// override EuiPage
margin-bottom: 0 !important; // sass-lint:disable-line no-important
}

.lnsWorkspacePanelWrapper__pageContentHeader--unsaved {
color: $euiTextSubduedColor;
}

.lnsWorkspacePanelWrapper__pageContentBody {
@include euiScrollBar;
flex-grow: 1;
Expand Down
30 changes: 6 additions & 24 deletions ...lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@ import './workspace_panel_wrapper.scss';

import React, { useCallback } from 'react';
import { i18n } from '@kbn/i18n';
import classNames from 'classnames';
import {
EuiPageContent,
EuiPageContentBody,
EuiPageContentHeader,
EuiFlexGroup,
EuiFlexItem,
EuiScreenReaderOnly,
Expand All @@ -27,7 +25,6 @@ export interface WorkspacePanelWrapperProps {
framePublicAPI: FramePublicAPI;
visualizationState: unknown;
dispatch: (action: Action) => void;
emptyExpression: boolean;
title?: string;
visualizationMap: Record<string, Visualization>;
visualizationId: string | null;
Expand All @@ -47,7 +44,6 @@ export function WorkspacePanelWrapper({
visualizationState,
dispatch,
title,
emptyExpression,
visualizationId,
visualizationMap,
datasourceMap,
Expand Down Expand Up @@ -105,26 +101,12 @@ export function WorkspacePanelWrapper({
</EuiFlexGroup>
</div>
<EuiPageContent className="lnsWorkspacePanelWrapper">
{!emptyExpression || title ? (
<EuiPageContentHeader
className={classNames('lnsWorkspacePanelWrapper__pageContentHeader', {
// eslint-disable-next-line @typescript-eslint/naming-convention
'lnsWorkspacePanelWrapper__pageContentHeader--unsaved': !title,
})}
>
<h1 data-test-subj="lns_ChartTitle">
{title ||
i18n.translate('xpack.lens.chartTitle.unsaved', { defaultMessage: 'Unsaved' })}
</h1>
</EuiPageContentHeader>
) : (
<EuiScreenReaderOnly>
<h1 data-test-subj="lns_ChartTitle">
{title ||
i18n.translate('xpack.lens.chartTitle.unsaved', { defaultMessage: 'Unsaved' })}
</h1>
</EuiScreenReaderOnly>
)}
<EuiScreenReaderOnly>
<h1 data-test-subj="lns_ChartTitle">
{title ||
i18n.translate('xpack.lens.chartTitle.unsaved', { defaultMessage: 'Unsaved' })}
</h1>
</EuiScreenReaderOnly>
<EuiPageContentBody className="lnsWorkspacePanelWrapper__pageContentBody">
{children}
</EuiPageContentBody>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/page_objects/lens_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
},

getTitle() {
return testSubjects.getVisibleText('lns_ChartTitle');
return testSubjects.getAttribute('lns_ChartTitle', 'innerText');
},

async getFiltersAggLabels() {
Expand Down