Conform Search Profiler application organization to other ES UI plugins

[cjcenizal]

This PR just moves files around, so all that's needed is verification that the folder structure looks good, and that the app works in the browser. This PR also updates the README with steps for testing.

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[yuliacech]

Hi @cjcenizal , thanks a lot for updating this plugin! I tested locally and all worked for me.
The new folder structure is definitely more similar to other plugins. A couple of non-blocking suggestions:

• renaming utils to lib as this seems to be used more often in our plugins
• moving files out of contexts folder into the root of application so that both contexts are close to index and app where they are used

[cjcenizal]

@elasticmachine merge upstream

[cjcenizal]

Thanks for the review @yuliacech! I implemented your suggestion of renaming utils to lib, but I left the contexts directory alone because I find it easier to identify module entry points and relationships if there are a minimal number of files in the root. However, I did realize that the styles directory is unorthodox, so I reorganized the styles to live alongside the components they decorate. Could you please take another look?

[ryankeairns]

I see this plugin has gone the extra mile with the use of _index.scss files :)

In most places, we see one SCSS file per .../component/xxxx/ directory and it matches the component name. Regardless, not an issue, just an observation for which I might be missing additional reasoning.

[cjcenizal]

Thanks @ryankeairns! Good to know. 👍

[yuliacech]

Hi @cjcenizal , tested locally with the new changes and everything worked for me. I haven't noticed any visual regressions either!

[cjcenizal]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: e6985d9

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
searchprofiler	85	89	+4

async chunks size

id	before	after	diff
searchprofiler	691.5KB	690.7KB	-871.0B

distributable file count

id	before	after	diff
default	48218	48221	+3

page load bundle size

id	before	after	diff
searchprofiler	49.8KB	48.3KB	-1.6KB

History

• 💚 Build #85283 succeeded 6bdf8e2
• 💚 Build #84932 succeeded 44f69af
• 💚 Build #84724 succeeded bf250fe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream