Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service overview tab and route #81972

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Service overview tab and route #81972

merged 2 commits into from
Oct 29, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 29, 2020

Placeholder tab and route for service overview page.

Fixes #81718.

image

@smith
Service overview tab and route
bb000d3 
Placeholder tab and route for service overview page.

Fixes elastic#81718.
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 29, 2020
@smith smith requested a review from a team as a code owner October 29, 2020 02:39
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
apm 1273 1275 +2

async chunks size

id before after diff
apm 3.2MB 3.2MB +11.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ogupte
ogupte approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Obv we'll be removing hardcoded values, as sections are implemented.

@smith smith merged commit 4ca013e into elastic:master Oct 29, 2020
@smith smith deleted the nls/overview-tab branch October 29, 2020 16:23
@smith smith mentioned this pull request Oct 29, 2020
Merged
smith added a commit to smith/kibana that referenced this pull request Oct 29, 2020
@smith
Service overview tab and route (elastic#81972)
9e70c1c 
Placeholder tab and route for service overview page.

Fixes elastic#81718.
smith added a commit that referenced this pull request Oct 30, 2020
@smith
Service overview tab and route (#81972) (#82046)
bafc89e 
Placeholder tab and route for service overview page.

Fixes #81718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Service overview tab and route
4 participants
@smith @elasticmachine @kibanamachine @ogupte