[DOCS] Fixes links in Developer docs

[KOTungseth]

Summary

Fixes the links in the Developer docs.

[elasticmachine]

Pinging @elastic/kibana-docs (Team:Docs)

[stacey-gammon]

cc @tylersmalley - can someone from ops help @KOTungseth out with fixing the broken links?

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[spalger]

@elasticmachine run elasticsearch-ci/docs

[spalger]

LGTM, though the link: tag/prefix seems unnecessary and inconsistent.

[tylersmalley]

Preview for anyone else wanting to take a look: https://kibana_81843.docs-preview.app.elstc.co/guide/en/kibana/7.10/development-tests.html

[tylersmalley]

LGTM, just a small nitpick to remove double slashes in the URL's.

[stacey-gammon]

I think the original links are still broken (at least I checked one and it was). I think @KOTungseth needs help figuring out what links to use to replace the broken ones with she listed in the main issue. :)

[jbudz]

Regarding the top comment for currently broken paths,

diff --git a/docs/developer/contributing/development-functional-tests.asciidoc b/docs/developer/contributing/development-functional-tests.asciidoc
index 368af041c51..6ef7c3d9513 100644
--- a/docs/developer/contributing/development-functional-tests.asciidoc
+++ b/docs/developer/contributing/development-functional-tests.asciidoc
@@ -289,8 +289,8 @@ Within a test Provider the API is exactly the same as the service providers API
 The `FunctionalTestRunner` comes with three built-in services:
 
 **config:**:::
-* Source: {kib-repo}/tree/{branch}/src/functional_test_runner/lib/config/config.ts[src/functional_test_runner/lib/config/config.ts]
-* Schema: {kib-repo}/tree/{branch}/src/functional_test_runner/lib/config/schema.ts[src/functional_test_runner/lib/config/schema.ts]
+* Source: {kib-repo}/tree/{branch}/packages/kbn-test/src/functional_test_runner/lib/config/config.ts[packages/kbn-test/src/functional_test_runner/lib/config/config.ts]
+* Schema: {kib-repo}/tree/branch}/packages/kbn-test/src/functional_test_runner/lib/config/schema.ts[packages/kbn-test/src/functional_test_runner/lib/config/schema.ts]
 * Use `config.get(path)` to read any value from the config file
 
 **log:**:::
@@ -299,7 +299,7 @@ The `FunctionalTestRunner` comes with three built-in services:
 * `log.verbose()`, `log.debug()`, `log.info()`, `log.warning()` all work just like console.log but produce more organized output
 
 **lifecycle:**:::
-* Source: {kib-repo}/tree/{branch}/src/functional_test_runner/lib/lifecycle.ts[src/functional_test_runner/lib/lifecycle.ts]
+* Source: {kib-repo}/tree/{branch}/packages/kbn-test/src/functional_test_runner/lib/lifecycle.ts[packages/kbn-test/src/functional_test_runner/lib/lifecycle.ts]
 * Designed primary for use in services
 * Exposes lifecycle events for basic coordination. Handlers can return a promise and resolve/fail asynchronously
 * Phases include: `beforeLoadTests`, `beforeTests`, `beforeEachTest`, `cleanup`
@@ -310,14 +310,14 @@ The `FunctionalTestRunner` comes with three built-in services:
 The {kib} functional tests define the vast majority of the actual functionality used by tests.
 
 **browser**:::
-* Source: link:{kib-repo}/tree/{branch}/test/functional/services/browser.ts[test/functional/services/browser.ts]
+* Source: {kib-repo}/tree/{branch}/test/functional/services/common/browser.ts[test/functional/services/common/browser.ts]
 * Higher level wrapper for `remote` service, which exposes available browser actions
 * Popular methods:
 ** `browser.getWindowSize()`
 ** `browser.refresh()`
 
 **testSubjects:**:::
-* Source: {kib-repo}/tree/{branch}/test/functional/services/test_subjects.ts[test/functional/services/test_subjects.ts]
+* Source: {kib-repo}/tree/{branch}/test/functional/services/common/test_subjects.ts[test/functional/services/common/test_subjects.ts]
 * Test subjects are elements that are tagged specifically for selecting from tests
 * Use `testSubjects` over CSS selectors when possible
 * Usage:
@@ -342,7 +342,7 @@ await testSubjects.click(‘containerButton’);
 ** `testSubjects.click(testSubjectSelector)` - Click a test subject in the page; throw if it can't be found after some time
 
 **find:**:::
-* Source: {kib-repo}/tree/{branch}/test/functional/services/find.ts[test/functional/services/find.ts]
+* Source: {kib-repo}/tree/{branch}/test/functional/services/common/find.ts[test/functional/services/common/find.ts]
 * Helpers for `remote.findBy*` methods that log and manage timeouts
 * Popular methods:
 ** `find.byCssSelector()`
diff --git a/docs/developer/plugin/external-plugin-functional-tests.asciidoc b/docs/developer/plugin/external-plugin-functional-tests.asciidoc
index b39d576d852..5bd75f1b8a7 100644
--- a/docs/developer/plugin/external-plugin-functional-tests.asciidoc
+++ b/docs/developer/plugin/external-plugin-functional-tests.asciidoc
@@ -69,7 +69,7 @@ export default async function ({ readConfigFile }) {
     }
 
     // more settings, like timeouts, mochaOpts, etc are
-    // defined in the config schema. See {blob}src/functional_test_runner/lib/config/schema.js[src/functional_test_runner/lib/config/schema.js]
+    // defined in the config schema. See {blob}packages/kbn-test/functional_test_runner/lib/config/schema.js[packages/kbn-test/functional_test_runner/lib/config/schema.js]
   };
 }

The patch may be slightly off, I manually wrote the changes in:

ftr paths: src/functional_test_runner -> packages/kbn-test
helper util paths: nested under a new common folder

[KOTungseth]

@elasticmachine merge upstream