[ML] Fix Anomaly Explorer charts time range to obey time picker range #80317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
walterra
approved these changes
Oct 13, 2020
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Oct 14, 2020
…elastic#80317) * [ML] Fix Anomaly Explorer charts time range to obey time picker range * [ML] Fix explorer_charts_container_service Jest tests
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Oct 14, 2020
…elastic#80317) * [ML] Fix Anomaly Explorer charts time range to obey time picker range * [ML] Fix explorer_charts_container_service Jest tests
This was referenced Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the time range used for plotting the anomaly charts in the Anomaly Explorer so that the min / max observe the time range set in the global time picker. Previously, as shown in #70244, depending on the bucket span of the job(s) and the time range in the view, the charts could extend past the range set in the time picker.
Also renamed the earliest / latest arguments of the
anomalyDataChangeandcalculateChartRangefunctions to make it clearer that they relate to the times selected in the swim lane, and not the time picker earliest / latest.Before:
After:
Note that the time span of the grey highlighted box in these charts is two hours, whereas it should be the same as the time range selected in the swim lane. This is being fixed in #80299.
Related to #70244