Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index pattern server api simpler dependency #80114

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 12, 2020

Summary

Server side index pattern api should use the scoped object client instead of the kibana request because its a simpler dependency and sufficient for its use.

@mattkime mattkime added Team:AppArch Feature:Data Views Data Views code and UI - index patterns before 8.0 v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 12, 2020
@mattkime mattkime requested a review from ppisljar October 12, 2020 04:12
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@mattkime mattkime marked this pull request as ready for review October 12, 2020 13:13
@mattkime mattkime requested a review from a team October 12, 2020 13:13
@mattkime mattkime requested a review from a team as a code owner October 12, 2020 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit f532e9d into elastic:master Oct 12, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request Oct 12, 2020
* index pattern server api simpler dependency
mattkime added a commit that referenced this pull request Oct 12, 2020
* index pattern server api simpler dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants