-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Usage collection] Expose the new es client and SO client #79044
Closed
TinaHeiligers
wants to merge
15
commits into
elastic:master
from
TinaHeiligers:usage-collection-esClients
Closed
[Usage collection] Expose the new es client and SO client #79044
TinaHeiligers
wants to merge
15
commits into
elastic:master
from
TinaHeiligers:usage-collection-esClients
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Failed CI Steps
Test FailuresJest Tests.src/plugins/usage_collection/server/collector.CollectorSet registers a collector set and runs lifecycle events should log debug status of fetching from the collectorStandard Out
Stack Trace
Jest Tests.src/plugins/usage_collection/server/collector.CollectorSet registers a collector set and runs lifecycle events should gracefully handle a collector fetch method throwing an errorStandard Out
Stack Trace
Jest Tests.src/plugins/usage_collection/server/collector.CollectorSet registers a collector set and runs lifecycle events should not break if isReady is not a functionStandard Out
Stack Trace
and 6 more failures, only showing the first 3. Metrics [docs]
To update your PR or re-run it, just comment with: |
Closing to revisit using a different strategy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Telemetry
release_note:breaking
release_note:enhancement
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handles step 3 in #74840 (comment).
As part of migrating over to the new Elasticsearch client, we provided the new client as an additional parameter to the
fetch
method in collectors and pass the client down as an additional collection config parameter.To use the new client forces plugin owners to provide the old client as well, which is not ideal.
This work refactors the way in which we provide the clients from individual arguments to an object, allowing plugins to select the client they wish to use.
This is a breaking change for Kibana developers and requires refactoring collectors in all the plugins that currently use
callCluster
.Checklist
Delete any items that are not applicable to this PR.
For maintainers
[skip-ci]