[Enterprise Search][App Search] Credentials Logic updates #78644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I renamed `showCredentialsForm` to be `shouldShowCredentialsForm` because it's a boolean, not an action. I renamed `toggleCredentialsForm` to `showCredentialsForm`, since it's only use to show the form, never to hide, and there is a separate action for hiding the form.
Changed to isActiveApiTokenExisting to follow better boolean naming practices
It now properly resets activeApiTokenRawName, which was not being reset to the default when the credentials form was opened.
cee-chen
reviewed
Sep 29, 2020
There was a problem hiding this comment.
LOVE these changes. Thanks so much for the atomic and super follow-able commits, it made reviewing a breeze!! 😍
One super minor alternative suggestion for isActiveApiTokenExisting naming, but if you feel strongly about it no worries, just let me know and we can move ahead.
BTW, I think the failed type check was a random bad commit in master unrelated to our code, so I'll go ahead and merge latest for you to try and get rid of it
...prise_search/public/applications/app_search/components/credentials/credentials_logic.test.ts
Show resolved
Hide resolved
...enterprise_search/public/applications/app_search/components/credentials/credentials_logic.ts
Outdated
Show resolved
Hide resolved
...prise_search/public/applications/app_search/components/credentials/credentials_logic.test.ts
Show resolved
Hide resolved
...prise_search/public/applications/app_search/components/credentials/credentials_logic.test.ts
Show resolved
Hide resolved
...prise_search/public/applications/app_search/components/credentials/credentials_logic.test.ts
Outdated
Show resolved
Hide resolved
...enterprise_search/public/applications/app_search/components/credentials/credentials_logic.ts
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
cee-chen
approved these changes
Sep 30, 2020
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 30, 2020
* master: (97 commits) [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746) [Discover] Fix functional time picker test permissions (elastic#78564) [ML] Fixing module datafeed overrides (elastic#78925) Adds some missing licenses to the CSV export (elastic#78719) [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973) [Lens] Stop using scripted metric to collect telemetry (elastic#78687) [Lens] fix wrong message in fields accordion (elastic#78924) [Enterprise Search][App Search] Credentials Logic updates (elastic#78644) [Monitoring] Disk usage alerting (elastic#75419) [SECURITY_SOLUTION] Trusted apps list expand/collapse details (elastic#78601) Update content on interstitial page (elastic#78881) chore(NA): include hjson as a prod dependency (elastic#78941) Fix empty meta fields input in Advanced Settings (elastic#78576) [Lens] Maintain order of operations in dimension panel (elastic#78864) Fix plugin doc title (elastic#78880) load apm-rum agent lazily (elastic#78760) [ML] Skip full ML access permission test Optimize charts plugin (elastic#78922) ui_actions service initial docs (elastic#78902) skip failing suite (elastic#78942) ...
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
JasonStoltz
added a commit
to JasonStoltz/kibana
that referenced
this pull request
Oct 5, 2020
JasonStoltz
added a commit
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a previous PR to add Credentials Logic, @constancecchen and I identified and discussed a number of optimizations. This PR implements those optimizations.
@constancecchen I am assigning this to you directly since we discussed these previously.
I kept the commits atomic, so I recommend following along in the commit log.
Checklist
Delete any items that are not applicable to this PR.
For maintainers